Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [linker script] fix section continuity issue #626

Merged
merged 4 commits into from
Jun 2, 2023
Merged

🐛 [linker script] fix section continuity issue #626

merged 4 commits into from
Jun 2, 2023

Conversation

stnolting
Copy link
Owner

This PR fixes a (rare!) situation where the address continuity between .text and .rodata sections is broken. Example:

 9c8:	f61ff0ef          	jal	ra,928 <__hidden___udivsi3>
 9cc:	40b00533          	neg	a0,a1
 9d0:	00028067          	jr	t0

Disassembly of section .rodata:

000009d8 <config_bank_manager-0x10>:
 9d8:	5241                	.2byte	0x5241
 9da:	2d54                	.2byte	0x2d54
 9dc:	474e                	.2byte	0x474e

Here, address 0x9d4 is missing creating a "gap" between .text and .rodata.

Find more information in #623.

@stnolting stnolting added bug Something isn't working SW software-related labels Jun 2, 2023
@stnolting stnolting self-assigned this Jun 2, 2023
@stnolting stnolting linked an issue Jun 2, 2023 that may be closed by this pull request
Random errors occuring with code that is not being executed (!!??) #623
Closed
@stnolting stnolting mentioned this pull request Jun 2, 2023
Closed
@stnolting stnolting changed the title [linker script] fix continuity issue [linker script] fix section continuity issue Jun 2, 2023
@stnolting
update version: 1.8.5.3
b625cb3
@stnolting
[rtl] update/re-link default IMEM image
2ef00c2 
generated from sw/example/demo_blink_led
@stnolting
[bootloader] re-link + minor edits
3533c90 
Add memory sync to bootloader (flush caches before booting the application).
@stnolting stnolting marked this pull request as ready for review June 2, 2023 11:40
@stnolting stnolting changed the title [linker script] fix section continuity issue 🐛 [linker script] fix section continuity issue Jun 2, 2023
@stnolting stnolting merged commit a630a08 into main Jun 2, 2023
8 checks passed
@stnolting stnolting deleted the fix_section_continuity branch June 2, 2023 11:48
@ucycg ucycg mentioned this pull request May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stnolting stnolting

Labels
bug Something isn't working SW software-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Random errors occuring with code that is not being executed (!!??)
1 participant
@stnolting