[sw/example/demo_spi_irq]: make read/write data pointer and busy flag… #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… volatile to ensure to have always the non cached version. Correct variable name 'uint32Fifo' to 'uint16Fifo' cause its as uint16_t defined.
stnolting
added
SW
|
Nice improvement! |
stnolting
approved these changes
Jan 6, 2023
|
Thanks for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Stephan,
I saw in the spi_irq driver that it could be better to have the data pointer
volatileto ensure in switching between ISR/non-ISR context to have the latest register value always available.BR,
Andreas