⚠️ [makefile] modify handling of MARCH and MABI variables #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pre-commit usage: `MARCH=-march=rv32i`, the `-march` should not be here Post-commit usage: `MARCH=rv32i`, this is more straightforward Same for `MABI=-mabi=...` -> `MABI=...`
stnolting
changed the title
umarcor
reviewed
Oct 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main software/application makefile variables
MARCHandMABIare used to define the machine architecture and the machine's architecture binary interface. These variable can be overridden when invoking make to customize compiler settings.Old Version (current state, pre-PR)
In the current (pre-PR) version these variables also require the
-marchand-mabiflags, respectively:MARCH=-march=rv32iMABI=-mabi=ilp32The
-marchand-mabiflags should not be used here.New Version (this PR)
This PR modifies the usage of those makefile flags as this seems to be more straightforward (and much cleaner):
MARCH=rv32iMABI=ilp32The modifications are not backward-compatible! Scripts that invoke the main software makefile need to be adapted.
@umarcor
Could you have a quick look that I did not oversee something? 😉