Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the board tops used by the open-source flows from
setups/examples
toosflow/board_top
.The original
setups/example
folder was meant as a board-wrappers folder that can be used by any toolchain (for example by Lattice Radiant). But I think it is cleaner and easier to understand if we have these board-tops inside the according toolchain folders even if there might be some redundancy (for example is ghdl-yosys and Radiant could use the same board tops).Another thing is that Radiant and ghdl-yosys seem to expect different primitive libraries:
neorv32/setups/examples/neorv32_UPduino_BoardTop_UP5KDemo.vhd
Lines 39 to 40 in 70edf18
vs.
neorv32/setups/radiant/UPduino_v3/neorv32_upduino_v3_top.vhd
Lines 45 to 46 in 70edf18