Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unbreak suggestions for emojis containing an underscore #8457

Merged

Conversation

caybro
Copy link
Member

@caybro caybro commented Nov 25, 2022

  • don't consider _ as a "punct" or invalid character, some emojis like flags do contain it in their name

Fixes: #8446

What does the PR do

Affected areas

StatusChatInput

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it

image

- don't consider `_` as a "punct" or invalid character, some emojis like
flags do contain it in their name

Fixes: #8446
@caybro caybro linked an issue Nov 25, 2022 that may be closed by this pull request
@status-im-auto
Copy link
Member

status-im-auto commented Nov 25, 2022

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c12a84f #1 2022-11-25 13:39:15 ~7 min imports 📄log
✔️ c12a84f #1 2022-11-25 13:39:28 ~7 min linux-cpp 📄log
✔️ c12a84f #1 2022-11-25 13:50:54 ~18 min linux 📦tgz
✔️ c12a84f #1 2022-11-25 13:58:22 ~26 min windows 💿exe
✔️ c12a84f #1 2022-11-25 13:59:02 ~27 min linux-e2e 📄log
c12a84f #1 2022-11-25 14:44:30 ~1 hr 12 min macos 📄log
c12a84f #2 2022-11-25 15:27:38 ~12 min macos 📄log

Copy link
Member

@0x-r4bbit 0x-r4bbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

Copy link
Contributor

@noeliaSD noeliaSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested!

@caybro caybro merged commit 6b7eea8 into master Nov 28, 2022
@caybro caybro deleted the 8446-typing-_-in-the-emoji-suggestions-popup-closes-it branch November 28, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typing _ in the emoji suggestions popup closes it
4 participants