Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing _ in the emoji suggestions popup closes it #8446

Closed
caybro opened this issue Nov 25, 2022 · 0 comments · Fixed by #8457
Closed

Typing _ in the emoji suggestions popup closes it #8446

caybro opened this issue Nov 25, 2022 · 0 comments · Fixed by #8457
Assignees
@caybro
Labels
bug Something isn't working

Comments

@caybro
Copy link
Member

caybro commented Nov 25, 2022

Bug Report

The goal was to insert some flag emoji (:flag_) but as soon as the user types the underscore, the popup is abruptly closed

Additional Information

  • Status desktop version: master
  • Operating System: linux
@caybro caybro added bug Something isn't working Chat labels Nov 25, 2022
@caybro caybro self-assigned this Nov 25, 2022
caybro added a commit that referenced this issue Nov 25, 2022
@caybro
fix: unbreak suggestions for emojis containing an underscore
c12a84f 
- don't consider `_` as a "punct" or invalid character, some emojis like
flags do contain it in their name

Fixes: #8446
@caybro caybro mentioned this issue Nov 25, 2022
Merged
1 task
@caybro caybro linked a pull request Nov 25, 2022 that will close this issue
fix: unbreak suggestions for emojis containing an underscore #8457
Merged
1 task
caybro added a commit that referenced this issue Nov 28, 2022
@caybro
fix: unbreak suggestions for emojis containing an underscore
6b7eea8 
- don't consider `_` as a "punct" or invalid character, some emojis like
flags do contain it in their name

Fixes: #8446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caybro caybro

Labels
bug Something isn't working
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: unbreak suggestions for emojis containing an underscore status-im/status-desktop
1 participant
@caybro