Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reactions distance to message content is inconsistent #8393

Merged

Conversation

caybro
Copy link
Member

@caybro caybro commented Nov 22, 2022

  • harmonize the margins/spacings in other message components
  • fix warnings
  • cleanup/remove some dead code

Fixes #8295

What does the PR do

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it

Snímek obrazovky z 2022-11-23 17-12-20
Snímek obrazovky z 2022-11-23 17-12-30
Snímek obrazovky z 2022-11-23 17-12-40

@caybro caybro linked an issue Nov 22, 2022 that may be closed by this pull request
@status-im-auto
Copy link
Member

status-im-auto commented Nov 22, 2022

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 933dbcd #1 2022-11-22 18:08:23 ~4 min linux-cpp 📦pkg
⁉️ 933dbcd #1 2022-11-22 18:09:11 ~5 min imports 📄log
✔️ 933dbcd #1 2022-11-22 18:16:50 ~12 min linux 📦tgz
⁉️ 933dbcd #1 2022-11-22 18:30:20 ~26 min e2e 📄log
✔️ 933dbcd #1 2022-11-22 18:31:26 ~27 min windows 📦exe
✔️ 933dbcd #1 2022-11-22 18:32:01 ~28 min macos 📦dmg
✔️ 8cb9f09 #2 2022-11-23 11:59:11 ~4 min imports 📦pkg
✔️ 8cb9f09 #2 2022-11-23 11:59:26 ~4 min linux-cpp 📦pkg
✔️ 8cb9f09 #2 2022-11-23 12:03:23 ~8 min macos 📦dmg
✔️ 8cb9f09 #2 2022-11-23 12:05:55 ~11 min linux 📦tgz
✖️ 8cb9f09 #1 2022-11-23 12:12:30 ~19 min e2e-e2e 📦pkg
✔️ 8cb9f09 #2 2022-11-23 12:23:45 ~28 min windows 📦exe
✔️ 8cb9f09 #2 2022-11-23 14:19:35 ~28 min e2e-e2e 📦pkg

- harmonize the margins/spacings in other message components
- fix warnings
- cleanup/remove some dead code

Fixes #8295
@caybro caybro force-pushed the 8295-chat-reactions-distance-to-message-content-is-inconsistent branch from 933dbcd to 8cb9f09 Compare November 23, 2022 11:53
@caybro caybro marked this pull request as ready for review November 23, 2022 16:13
@caybro caybro merged commit 2bf2861 into master Nov 23, 2022
@caybro caybro deleted the 8295-chat-reactions-distance-to-message-content-is-inconsistent branch November 23, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chat: reactions distance to message content is inconsistent
4 participants