fix: reactions distance to message content is inconsistent

- harmonize the margins/spacings in other messagage components - fix warnings - cleanup/remoe some dead code Fixes #8295
status-im · Nov 22, 2022 · 933dbcd · 933dbcd
1 parent 6609ebd
commit 933dbcd
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 16 deletions.
diff --git a/ui/StatusQ/src/StatusQ/Components/StatusMessage.qml b/ui/StatusQ/src/StatusQ/Components/StatusMessage.qml
@@ -389,7 +389,6 @@ Control {
                             id: emojiReactionsPanel
 
                             emojiReactionsModel: root.reactionsModel
-                            store: root.messageStore
                             icons: root.reactionIcons
 
                             onHoverChanged: {

diff --git a/ui/StatusQ/src/StatusQ/Components/private/statusMessage/StatusMessageEmojiReactions.qml b/ui/StatusQ/src/StatusQ/Components/private/statusMessage/StatusMessageEmojiReactions.qml
@@ -20,7 +20,6 @@ Item {
     signal hoverChanged(bool hovered)
     signal toggleReaction(int emojiID)
 
-    property var store
     property bool isCurrentUser
     property var emojiReactionsModel
 

diff --git a/ui/imports/shared/views/chat/InvitationBubbleView.qml b/ui/imports/shared/views/chat/InvitationBubbleView.qml
@@ -57,16 +57,12 @@ Item {
 
     Connections {
         target: root.store.communitiesModuleInst
-        onCommunityChanged: function (communityId) {
+        function onCommunityChanged(communityId) {
             if (communityId === root.communityId) {
                 d.reevaluate()
             }
         }
-    }
-
-    Connections {
-        target: root.store.communitiesModuleInst
-        onCommunityAdded: function (communityId) {
+        function onCommunityAdded(communityId) {
             if (communityId === root.communityId) {
                 d.reevaluate()
             }
@@ -136,7 +132,6 @@ Item {
     //                        }
                         }
                         wrapMode: Text.WordWrap
-                        font.pixelSize: 15
                     }
                 }
 
@@ -190,7 +185,6 @@ Item {
 
                             text: d.invitedCommunity.description
                             wrapMode: Text.WrapAtWordBoundaryOrAnywhere
-                            font.pixelSize: 15
                             color: Theme.palette.directColor1
                         }
 

diff --git a/ui/imports/shared/views/chat/LinksMessageView.qml b/ui/imports/shared/views/chat/LinksMessageView.qml
@@ -28,8 +28,7 @@ Column {
 
     signal imageClicked(var image)
 
-    spacing: Style.current.halfPadding
-    height: childrenRect.height
+    spacing: 4
 
     QtObject {
         id: d
@@ -275,7 +274,6 @@ Column {
                 isCurrentUser: root.isCurrentUser
                 anchors.horizontalCenter: parent.horizontalCenter
                 anchors.top: parent.top
-                anchors.topMargin: 1
                 playing: root.messageStore.playAnimation
                 isOnline: root.store.mainModuleInst.isOnline
             }
@@ -292,7 +290,6 @@ Column {
                 anchors.right: parent.right
                 anchors.leftMargin: Style.current.smallPadding
                 anchors.rightMargin: Style.current.smallPadding
-                color: Theme.palette.directColor1
             }
 
             StatusBaseText {
@@ -304,7 +301,7 @@ Column {
                 anchors.top: linkTitle.bottom
                 anchors.topMargin: 2
                 anchors.left: linkTitle.left
-                anchors.bottomMargin: Style.current.smallPadding
+                anchors.bottomMargin: Style.current.halfPadding
             }
 
             MouseArea {
@@ -370,7 +367,6 @@ Column {
                 wrapMode: Text.WordWrap
                 anchors.top: unfurlingImage.bottom
                 anchors.topMargin: Style.current.halfPadding
-                font.pixelSize: 15
                 color: Theme.palette.directColor1
             }