fix(BackUpSeed): Confirm # word input had no focus #7958
Conversation
Jenkins Builds
|
| @@ -19,6 +19,14 @@ StatusStackModal { | |||
|
|
|||
| property var privacyStore | |||
|
|
|||
| onCurrentIndexChanged: { | |||
| if (currentIndex === 2) { | |||
There was a problem hiding this comment.
My proposition is to put it directly to components:
BackupSeedStepBase {
id: confirmFirstWord
...
onVisibleChanged: if (visible) forceInputFocus()
}
to avoid comparing to index numbers and better fulfill solid's open-close principle.
There was a problem hiding this comment.
hey @micieslak visibility in StackLayout items is not working this way unless it's explicitly set like visible: stack.currentIndex === 1, visible: stack.currentIndex === 2 etc . so it's kind of the same thing - the current index should be checked and compared. See video for credibility :D
https://user-images.githubusercontent.com/31625338/196982590-8daf01f8-011a-488a-835d-4c7352fe4116.mov
There was a problem hiding this comment.
Hey @alexandraB99. I found the source of misunderstanding :) StackLayout works exactly this way - current item is visible, the rest is not visible. But... we are not using raw StackLayout. We are using StatusAnimatedStack which is buggy and sets visible in a strange way, exactly as you presented (I was able to reproduce that as well). On this movie I print visibility after temporarily changing to plain StackLayout:
Kazam_screencast_00071.webm
Probably StatusAnimatedStack should have been based on StackView which has build-in support for animated transitions, but ofc it's a different story.
So I agree on current solution, but I would at least add some comment about the reason why it's done this way, and, ideally, create a new ticket for that bug in StatusAnimatedStack. Wdyt?
There was a problem hiding this comment.
@micieslak comment added and issue, there you go: #8024
alexandraB99
force-pushed
the
fix/issue-7680
branch
from
02dcaa7
to
a03d0ff
Compare
Closes #7680
What does the PR do
BackUpSeedPhrasePopup steps 2+3 had no focus in text input
Affected areas
BackUpSeedPhrasePopup
Screenshot of functionality (including design for comparison)
seedf.mov