-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Profile): Added menu to remove profile image #6862
Conversation
febad28
to
72647e0
Compare
Jenkins Builds
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Nice that you also cleaned up the old code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
@igor-sirotin I set up a profile image during onboarding and it did not appear in the settings, did u see that as well? |
@anastasiyaig, Yeap, I've opened a separate issue for that: #6861 |
Just to jump in, it was working after I introduced keycard flow, so must be something recently changed. |
@saledjenic, Actually it hasn't been working for at least 2 monts already 🤦 |
Fixes #5921
What does the PR do
Affected areas
Profile settings
Screenshot of functionality (including design for comparison)
This doesn't actually have designs. I discuess with John to first implement it the way I see it, then decide if it's ok.
But I was reffering to this design: https://www.figma.com/file/idUoxN7OIW2Jpp3PMJ1Rl8/%E2%9A%99%EF%B8%8F-Settings-%7C-Desktop?node-id=1116%3A108254
2022-08-07.23.59.27.mov