Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various image croppers and their bugs #5921

Closed
1 of 2 tasks
igor-sirotin opened this issue May 30, 2022 · 1 comment · Fixed by #6862 or #6994
Closed
1 of 2 tasks

Various image croppers and their bugs #5921

igor-sirotin opened this issue May 30, 2022 · 1 comment · Fixed by #6862 or #6994
Assignees
Labels
bug Something isn't working

Comments

@igor-sirotin
Copy link
Contributor

igor-sirotin commented May 30, 2022

Bug Report

First of all, there's currently a mess of components for cropping images.
There are various implementations of the cropper, but there should be just reusable one.

And I also noticed these bugs:

  1. During onboarding, after selecting the image:
  2. There's no way to remove the profile/community image, only replacing is available
  3. The designs doesn't have the behavior of image uploading failure - not a bug
  4. There's a bunch of leftover unused files, e.g.:
    • UploadProfilePicModal
    • ChangeProfilePicModal
    • EditCroppedImagePanel
  5. There're also croppers coming from feat(Communities/Settings): Integrate banner editing in communities edit view #5437
@igor-sirotin igor-sirotin added the bug Something isn't working label May 30, 2022
@igor-sirotin igor-sirotin self-assigned this May 30, 2022
@elina2015
Copy link

@igor-sirotin hey, could you kindly add a pull request for this task? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
3 participants