Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): bring back copy wallet address #6798

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

stefandunca
Copy link
Contributor

Fixes: #6659

Depends on StatusQ's StatusAddressPanel generic control PR

@status-im-auto
Copy link
Member

status-im-auto commented Aug 3, 2022

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ afbac51 #1 2022-08-03 13:03:21 ~8 min macos 📦dmg
✔️ afbac51 #1 2022-08-03 13:05:17 ~10 min linux 📦tgz
✔️ afbac51 #1 2022-08-03 13:30:50 ~36 min windows 📦exe
✔️ 5efd1c7 #2 2022-08-04 11:22:54 ~10 min linux 📦tgz
✔️ 5efd1c7 #2 2022-08-04 11:27:46 ~15 min macos 📦dmg
✔️ 5efd1c7 #2 2022-08-04 11:33:06 ~20 min windows 📦exe
Commit #️⃣ Finished (UTC) Duration Platform Result
e3f22fa #1 2022-08-05 14:46:08 ~6 min e2e 📄log
✔️ e3f22fa #3 2022-08-05 14:47:27 ~8 min macos 📦dmg
✔️ e3f22fa #3 2022-08-05 14:51:01 ~11 min linux 📦tgz
✔️ e3f22fa #3 2022-08-05 15:10:55 ~31 min windows 📦exe
✔️ 39c2ff5 #4 2022-08-05 15:15:38 ~10 min linux 📦tgz

@stefandunca stefandunca marked this pull request as ready for review August 4, 2022 11:09
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs a rebase

@elina2015 elina2015 removed the request for review from a team August 4, 2022 18:12
@glitchminer
Copy link
Contributor

Checked against two wallets in same account - copy function in wallet brings back same wallet address as expected from receive modal.

image

Copy link
Contributor

@glitchminer glitchminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved.

Depends on StatusQ's StatusAddressPanel generic control

Fixes: #6659
@stefandunca stefandunca merged commit 2398b67 into master Aug 5, 2022
@stefandunca stefandunca deleted the fix_copy_address-6659 branch August 5, 2022 15:05
micieslak pushed a commit that referenced this pull request Sep 21, 2022
Provides frame, prefix icon and copy operation int addition to StatusAddress

Updates: #6798
micieslak pushed a commit that referenced this pull request Sep 21, 2022
Provides frame, prefix icon and copy operation int addition to StatusAddress

Updates: #6798
micieslak pushed a commit that referenced this pull request Sep 21, 2022
Provides frame, prefix icon and copy operation int addition to StatusAddress

Updates: #6798
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot copy address from wallet
5 participants