Skip to content
This repository has been archived by the owner on Sep 26, 2022. It is now read-only.

feature(StatusAddressPanel): Implement generic address display control #826

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

stefandunca
Copy link
Contributor

@stefandunca stefandunca commented Aug 3, 2022

Showcase

Some images and video is not up to date, tweaked and fixed in the meantime

App

Light theme
image

Dark theme
image

StatusQ vs. Design
image

Hovered
image

Wallet settings
image

Sandbox

StatusAddressPanel.mov

Checklist

  • follow conventional commits
  • add documentation if necessary (new component, new feature)
  • update sandbox app
  • test changes in both light and dark theme?
  • is this a breaking change?
  • test changes in status-desktop

@stefandunca stefandunca changed the title feature(Components): Implement generic address display control feature(StatusAddressPanel): Implement generic address display control Aug 4, 2022
@stefandunca stefandunca requested review from a team, MishkaRogachev, caybro and glitchminer and removed request for a team August 4, 2022 11:07
@stefandunca stefandunca marked this pull request as ready for review August 4, 2022 11:08
Copy link
Contributor

@MishkaRogachev MishkaRogachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layouts are cool

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some minor stuff only

src/StatusQ/Components/StatusAddressPanel.qml Outdated Show resolved Hide resolved
src/StatusQ/Components/StatusAddress.qml Outdated Show resolved Hide resolved
Provides frame, prefix icon and copy operation int addition to StatusAddress

Updates: #6798
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@stefandunca stefandunca merged commit 10d312e into master Aug 5, 2022
@stefandunca stefandunca deleted the address_control-6659 branch August 5, 2022 15:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants