Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(onboarding): 12 18 and 24 seed phrase tests #6399

Merged
merged 7 commits into from
Jul 15, 2022
Merged

test(onboarding): 12 18 and 24 seed phrase tests #6399

merged 7 commits into from
Jul 15, 2022

Conversation

OlufemiAdeOlusile
Copy link
Contributor

@OlufemiAdeOlusile OlufemiAdeOlusile commented Jul 10, 2022 •
edited
Loading

What does the PR do

This PR tests positive and negative flows for 12, 18, 24 seed phrase via Squish
#6274
#6275
#6276

Affected areas

Depends on Icon change (include Object Name) via Status Q status-im/StatusQ#761

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it

Cool Spaceship Picture

femi added 2 commits July 10, 2022 15:54
@status-im-auto
Copy link
Member

status-im-auto commented Jul 10, 2022 •
edited
Loading

Jenkins Builds

Click to see older builds (12)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 403a745 #1 2022-07-10 15:13:42 ~8 min macos 📦dmg
✔️ 403a745 #1 2022-07-10 15:14:54 ~9 min linux 📦tgz
✔️ 403a745 #1 2022-07-10 15:26:57 ~21 min windows 📦exe
✔️ e305b5c #2 2022-07-12 16:40:21 ~10 min linux 📦tgz
✔️ e305b5c #2 2022-07-12 16:46:06 ~15 min macos 📦dmg
✔️ e305b5c #2 2022-07-12 16:53:53 ~23 min windows 📦exe
✔️ ffdc573 #3 2022-07-12 16:44:13 ~8 min macos 📦dmg
✔️ ffdc573 #3 2022-07-12 16:46:08 ~10 min linux 📦tgz
✔️ ffdc573 #3 2022-07-12 16:58:06 ~22 min windows 📦exe
✔️ ae452eb #4 2022-07-13 08:38:21 ~8 min macos 📦dmg
✔️ ae452eb #4 2022-07-13 08:40:00 ~9 min linux 📦tgz
✔️ ae452eb #4 2022-07-13 08:50:42 ~20 min windows 📦exe
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f5b2842 #5 2022-07-13 13:24:08 ~9 min macos 📦dmg
✔️ f5b2842 #5 2022-07-13 13:26:35 ~12 min linux 📦tgz
✔️ f5b2842 #5 2022-07-13 13:36:21 ~21 min windows 📦exe
✔️ 035e856 #6 2022-07-15 00:35:04 ~9 min linux 📦tgz
✔️ 035e856 #6 2022-07-15 00:42:32 ~17 min macos 📦dmg
✔️ 035e856 #6 2022-07-15 00:46:36 ~21 min windows 📦exe

noeliaSD
noeliaSD reviewed Jul 11, 2022
View reviewed changes
test/ui-test/testSuites/suite_status/tst_statusSignUp/test.feature Outdated
| tester123 | TesTEr16843/!@) | TesTEr16843/!@01 |


Scenario: User signs up with imported 12 seed phrase
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identation

noeliaSD
noeliaSD reviewed Jul 11, 2022
View reviewed changes
test/ui-test/testSuites/suite_status/tst_statusSignUp/test.feature Outdated
And user clicks on the following ui-component mainWindow_submitButton_StatusButton
When user signs up with username tester124 and password TesTEr16843/!@00
Then the user lands on the signed in app
When the user opens app settings screen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why opening settings and wallet section is part of sign up suite

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just following the Testrail lol
https://ethstatus.testrail.net/index.php?/cases/view/702169&group_by=cases:section_id&group_order=asc&display_deleted_cases=0&group_id=50829

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't have access to TestRail.. so, is it part of SignUp test case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am following the manual test cases now.

noeliaSD
noeliaSD reviewed Jul 11, 2022
View reviewed changes
test/ui-test/testSuites/suite_status/tst_statusSignUp/test.feature Outdated

# Input wrong password format in both new password and confirmation input and verify create password button is not enabled
When user inputs the following <wrongpassword> with ui-component loginView_passwordInput
And user inputs the following <wrongpassword> with ui-component mainWindow_inputValue_StyledTextField
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the ui-component name be more specific? By reading this, I'm not sure which component are you referring and in which page are you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will look at this. Thanks

noeliaSD
noeliaSD requested changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@noeliaSD noeliaSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tryied to run the scenarios related to seed phrases and I get the following test failures (same happens with chatFlow once the user lands into the app, after the onboarding process):

Screenshot 2022-07-11 at 10 09 00

Screen.Recording.2022-07-11.at.10.10.03.mov

@noeliaSD
Copy link
Contributor

And also, please follow commit conventions!! we can write squish related commits like this:
"test(test-scenario-section-name): desc" --> "test(onboarding): desc"

Update trailing spaces
ae452eb 
Update UI component mainWindow_Password_textField
@OlufemiAdeOlusile OlufemiAdeOlusile changed the title Feat/login 12 seed phrase test(onboarding): 12 18 and 24 seed phrase tests Jul 13, 2022
@OlufemiAdeOlusile
Copy link
Contributor Author

OlufemiAdeOlusile commented Jul 13, 2022 •
edited
Loading

I've tryied to run the scenarios related to seed phrases and I get the following test failures (same happens with chatFlow once the user lands into the app, after the onboarding process):

Screenshot 2022-07-11 at 10 09 00

Screen.Recording.2022-07-11.at.10.10.03.mov

Updated here #6399 (comment)
Depends on Icon change (include Object Name) via Status Q status-im/StatusQ#761

femi added 2 commits July 13, 2022 14:14
Update Status ICon
f5b2842
Update Settings NavBar
035e856 
Update FileManager
Update ObjectMapper
noeliaSD
noeliaSD approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@noeliaSD noeliaSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new changes the scenario run correctly.

@OlufemiAdeOlusile OlufemiAdeOlusile merged commit 971d12f into master Jul 15, 2022
@OlufemiAdeOlusile OlufemiAdeOlusile deleted the feat/login-12-seed-phrase branch July 15, 2022 08:27
@iurimatias iurimatias mentioned this pull request May 27, 2023
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iurimatias iurimatias iurimatias approved these changes

@noeliaSD noeliaSD noeliaSD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OlufemiAdeOlusile @status-im-auto @noeliaSD @iurimatias