This repository has been archived by the owner on Sep 26, 2022. It is now read-only.
chore(StatusIcon): Include Object Name to Status Icon #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help Squish tests easily identify Icons. Which is used in test case status-im/status-desktop#6274
noeliaSD
reviewed
Jul 11, 2022
noeliaSD
approved these changes
Jul 11, 2022
There was a problem hiding this comment.
LGTM! Please follow commits convention. You can check it here: https://www.conventionalcommits.org/en/v1.0.0/
In this case it could be: "chore(StatusIcon): Your commit description"
This will help Squish tests easily identify Icons. Which is used in test case status-im/status-desktop#6274
This will help Squish tests easily identify Icons. Which is used in test case status-im/status-desktop#6274
BREAKING CHANGE: isMutualContact is replaced by isContact anywhere it was used
call `updateRightButtons()` also on creation to correctly initialize the Next and Finish buttons in derived classes, when one overrrides these can be seen in the Backup Seed dialog where the Next button is not enabled even though all 3 boxes are checked
…StatusMenuItems font attributes (#749) Required by #6090
OlufemiAdeOlusile
changed the title
OlufemiAdeOlusile
changed the title
OlufemiAdeOlusile
changed the title
alexandraB99
approved these changes
Jul 12, 2022
added 4 commits
July 12, 2022 16:55
This will help Squish tests easily identify Icons. Which is used in test case status-im/status-desktop#6274
This will help Squish tests easily identify Icons. Which is used in test case status-im/status-desktop#6274
This will help Squish tests easily identify Icons. Which is used in test case status-im/status-desktop#6274
…to feat/status-icon-object-name
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of status-im/status-desktop#6274
Checklist
feat(StatusListItem): ...feat(StatusQ.Controls): ...BREAKING CHANGEcommit message section