Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gif popup): close the popup after sending a GIF #6364

Merged
merged 1 commit into from
Jul 5, 2022
Merged

fix(gif popup): close the popup after sending a GIF #6364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/imports/shared/status/StatusChatInput.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Rectangle {
property var emojiPopup: null
// Use this to only enable the Connections only when this Input opens the Emoji popup
property bool emojiPopupOpened: false
property bool closeGifPopupAfterSelection: false
property bool closeGifPopupAfterSelection: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder why this was false in the first place..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea... well it was introduced earlier to prevent a crash (due to adding a GIF to favs while the popup was being destroyed), but even more curious is the fact that this and the emoji popup have totally different logic for opening/closing/handling the image selected

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh and those callbacks 😮

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The boolean was introduced here: a70d800


property bool emojiEvent: false;
property bool paste: false;
Expand Down