fix(gif popup): close the popup after sending a GIF #6364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caybro
changed the title
0x-r4bbit
reviewed
Jul 5, 2022
| @@ -35,7 +35,7 @@ Rectangle { | |||
| property var emojiPopup: null | |||
| // Use this to only enable the Connections only when this Input opens the Emoji popup | |||
| property bool emojiPopupOpened: false | |||
| property bool closeGifPopupAfterSelection: false | |||
| property bool closeGifPopupAfterSelection: true | |||
There was a problem hiding this comment.
Wonder why this was false in the first place..
There was a problem hiding this comment.
No idea... well it was introduced earlier to prevent a crash (due to adding a GIF to favs while the popup was being destroyed), but even more curious is the fact that this and the emoji popup have totally different logic for opening/closing/handling the image selected
There was a problem hiding this comment.
The boolean was introduced here: a70d800
igor-sirotin
approved these changes
Jul 5, 2022
0x-r4bbit
approved these changes
Jul 5, 2022
caybro
deleted the
6083-the-gif-dialog-doesnt-disappear-after-sending-a-gif
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6083
What does the PR do
By default, enable automatically closing the GIF popup after having sent a GIF to the chat
Affected areas
Chat, chat input
Screenshot of functionality
Zaznam.obrazovky.z.5.7.2022.10.53.33.webm