Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHERRY-PICK: fix(StatusCommunityCard): fix some visual glitches #14583

Merged

Conversation

caybro
Copy link
Member

@caybro caybro commented May 2, 2024

Cherry pick of #14564 to release/2.28.x branch

What does the PR do

  • correct propagation of hover events, fixes card flicker
  • improve the ugly thick border
  • token icons are now correctly rounded
  • fix text descent lines are cut of ("y" and "p" truncated at the bottom) due to excessive clipping, set correct max line count
  • fix tag outline not being visible in dark mode
  • add/update the corresponding SB page, with more controls to play around with the different params

Fixes #14555

Affected areas

StatusCommunityCard

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it

See the original PR

- correct propagation of hover events, fixes card flicker
- improve the ugly thick border
- token icons are now correctly rounded
- fix text descent lines are cut of ("y" and "p" truncated at the
bottom) due to excessive clipping, set correct max line count
- fix tag outline not being visible in dark mode
- add/update the corresponding SB page, with more controls to play
around with the different params

Fixes #14555
@caybro caybro requested a review from jrainville May 2, 2024 18:32
@caybro caybro changed the title CHERRY-PICK: fix(StatusCard): fix some visual glitches CHERRY-PICK: fix(StatusCommunityCard): fix some visual glitches May 2, 2024
@status-im-auto
Copy link
Member

status-im-auto commented May 2, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9b80eec #1 2024-05-02 18:39:00 ~6 min tests/nim 📄log
✔️ 9b80eec #1 2024-05-02 18:41:25 ~8 min macos/aarch64 🍎dmg
✔️ 9b80eec #1 2024-05-02 18:44:50 ~11 min macos/x86_64 🍎dmg
✔️ 9b80eec #1 2024-05-02 18:49:34 ~16 min tests/ui 📄log
✔️ 9b80eec #1 2024-05-02 18:53:26 ~20 min linux/x86_64 📦tgz
✔️ 9b80eec #1 2024-05-02 19:06:58 ~34 min windows/x86_64 💿exe

@jrainville jrainville merged commit 74b92dd into release/2.28.x May 2, 2024
7 of 8 checks passed
@jrainville jrainville deleted the fix/backport-statuscommunitycard-ui-fixes branch May 2, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants