fix(StatusCommunityCard): fix some visual glitches #14564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
- correct propagation of hover events, fixes card flicker
- improve the ugly thick border
- token icons are now correctly rounded
- fix text descent lines are cut of ("y" and "p" truncated at the
bottom) due to excessive clipping, set correct max line count
- fix tag outline not being visible in dark mode
- add/update the corresponding SB page, with more controls to play
around with the different params
Fixes #14555
caybro
force-pushed
the
14555-statuscard-fix-visual-glitches
branch
from
c1d3810
to
3d76b0e
Compare
caybro
changed the title
Seitseman
approved these changes
May 2, 2024
jrainville
approved these changes
May 2, 2024
Sure, I can do the backport PR later today or tomorrow |
1 task
@jrainville created the backport PR at #14583 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #14555
Affected areas
StatusCommunityCard
Screenshot of functionality (including design for comparison)
Zaznam.obrazovky.z.2024-05-01.15-31-30.webm
Correctly rounded token icons:
