fix(Profile flow): Send a contact request (CR) #13598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make `SendContactRequestModal.qml` use the common dialog, use the contact details if we already have it - make some minimal changes to the "Send ID verification" flow since it shares the same dialog - simplify the `CommonContactDialog.qml` footer/buttons handling - adjust the menu item texts - emit toasts when the action is performed - display a tooltip over the compressed elided key Fixes #13518
caybro
requested review from
MishkaRogachev,
alexjba,
micieslak and
igor-sirotin
Jenkins Builds
|
✔️ status-desktop/prs/linux/x86_64/tests-nim/PR-13598#1 🔹 ~5 min 54 sec 🔹 032b6b2 🔹 📦 tests/nim package |
MishkaRogachev
approved these changes
Feb 16, 2024
| @@ -38,8 +38,8 @@ QtObject { | |||
| signal openImagePopup(var image, string url) | |||
| signal openProfilePopupRequested(string publicKey, var parentPopup, var cb) | |||
| signal openActivityCenterPopupRequested() | |||
| signal openSendIDRequestPopup(string publicKey, var cb) | |||
| signal openContactRequestPopup(string publicKey, var cb) | |||
| signal openSendIDRequestPopup(string publicKey, var contactDetails, var cb) | |||
There was a problem hiding this comment.
I don't want to open a pandora's box, but what if contact details get changed?
There was a problem hiding this comment.
Yeah good point, some of those dialogs already handle that, some don't. My (ultimate) plan is to unify that in the common dialog. Here the reason for passing var contactDetails thru the signal is simply saving the call when we already have the info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
SendContactRequestModal.qmluse the common dialog, use the contact details if we already have itCommonContactDialog.qmlfooter/buttons handlingFixes #13518
Affected areas
SendContactRequestModal
Screenshot of functionality (including design for comparison)
Zaznam.obrazovky.z.2024-02-16.13-06-49.webm