Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profile flow] Send a contact request (CR) #13518

Closed
Tracked by #13500
caybro opened this issue Feb 12, 2024 · 0 comments · Fixed by #13598
Closed
Tracked by #13500

[Profile flow] Send a contact request (CR) #13518

caybro opened this issue Feb 12, 2024 · 0 comments · Fixed by #13598
Assignees
@caybro
Labels
E:Desktop Contact Requests Anything related to mutual contacts and sending/receiving contact requests E:Desktop Profile Showcase Implementation of the Profile showcase feature
Milestone
2.28.0 Beta

Comments

@caybro
Copy link
Member

caybro commented Feb 12, 2024 •
edited
Loading

image

Figma: https://www.figma.com/file/ibJOTPlNtIxESwS96vJb06/%F0%9F%91%A4-Profile-%7C-Desktop?type=design&node-id=2460-197035&mode=design&t=qVMy2WcrL4fvxnwK-0
@caybro caybro mentioned this issue Feb 12, 2024
Closed
12 tasks
@caybro caybro self-assigned this Feb 12, 2024
@caybro caybro added ui-team E:Desktop Profile Showcase Implementation of the Profile showcase E:Desktop Contact Requests Anything related to mutual contacts and sending/receiving contact requests labels Feb 12, 2024
@caybro caybro added this to the 2.28.0 Beta milestone Feb 12, 2024
caybro added a commit that referenced this issue Feb 16, 2024
@caybro
fix(Profile flow): Send a contact request (CR)
032b6b2 
- make `SendContactRequestModal.qml` use the common dialog, use the
contact details if we already have it
- make some minimal changes to the "Send ID verification" flow since it
shares the same dialog
- simplify the `CommonContactDialog.qml` footer/buttons handling
- adjust the menu item texts
- emit toasts when the action is performed
- display a tooltip over the compressed elided key

Fixes #13518
@caybro caybro mentioned this issue Feb 16, 2024
Merged
1 task
@caybro caybro linked a pull request Feb 16, 2024 that will close this issue
fix(Profile flow): Send a contact request (CR) #13598
Merged
1 task
caybro added a commit that referenced this issue Feb 16, 2024
@caybro
fix(Profile flow): Send a contact request (CR)
2fa6596 
- make `SendContactRequestModal.qml` use the common dialog, use the
contact details if we already have it
- make some minimal changes to the "Send ID verification" flow since it
shares the same dialog
- simplify the `CommonContactDialog.qml` footer/buttons handling
- adjust the menu item texts
- emit toasts when the action is performed
- display a tooltip over the compressed elided key

Fixes #13518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caybro caybro

Labels
E:Desktop Contact Requests Anything related to mutual contacts and sending/receiving contact requests E:Desktop Profile Showcase Implementation of the Profile showcase feature
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
2.28.0 Beta
Development

Successfully merging a pull request may close this issue.

fix(Profile flow): Send a contact request (CR) status-im/status-desktop
2 participants
@caybro @alexandraB99