fix: timestamp shows yesterday for a message received 3 days ago #13506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caybro
requested review from
micieslak,
igor-sirotin,
alexjba and
jrainville
Jenkins BuildsClick to see older builds (16)
|
micieslak
reviewed
Feb 12, 2024
micieslak
reviewed
Feb 12, 2024
caybro
force-pushed
the
11460-message-timestamp-in-a-channel-shows-yesterday-for-a-message-received-3-days-ago
branch
2 times, most recently
from
bd13078
to
55af6b1
Compare
igor-sirotin
approved these changes
Feb 12, 2024
micieslak
reviewed
Feb 12, 2024
caybro
force-pushed
the
11460-message-timestamp-in-a-channel-shows-yesterday-for-a-message-received-3-days-ago
branch
from
55af6b1
to
62e0568
Compare
caybro
force-pushed
the
11460-message-timestamp-in-a-channel-shows-yesterday-for-a-message-received-3-days-ago
branch
from
62e0568
to
d8e303d
Compare
caybro
deleted the
11460-message-timestamp-in-a-channel-shows-yesterday-for-a-message-received-3-days-ago
branch
- introduce one global update timer, to be used in various components for date/time sensitive updates (StatusSharedUpdateTimer) - this timer runs only when the app is/becomes active - use the timer's `triggered()` signal to update the timestamp label when needed; ie. if it's to display a relative timestamp and it's currently visible Fixes #11460
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes wrong message timestamp in a channel when the relative date changes (due to time going over midnight, HW clock skews or timezone/DST changes)
triggered()signal to update the timestamp label when needed; ie. if it's to display a relative timestamp and it's currently visibleFixes #11460
Affected areas
StatusTimeStampLabel
Screenshot of functionality (including design for comparison)
Before midnight:
After midnight:
