fix: timestamp shows yesterday for a message received 3 days ago

- introduce one global update timer, to be used in various components for date/time sensitive updates (StatusSharedUpdateTimer) - this timer runs only when the app is/becomes active - use the timer's `triggered()` signal to update the timestamp label when needed; ie. if it's to display a relative timestamp and it's currently visible Fixes #11460
status-im · Feb 12, 2024 · 55af6b1 · 55af6b1
1 parent 4b24497
commit 55af6b1
Show file tree

Hide file tree

Showing 4 changed files with 39 additions and 3 deletions.
diff --git a/ui/StatusQ/src/StatusQ/Components/StatusTimeStampLabel.qml b/ui/StatusQ/src/StatusQ/Components/StatusTimeStampLabel.qml
@@ -12,7 +12,24 @@ StatusBaseText {
     color: Theme.palette.baseColor1
     font.pixelSize: 10
     visible: !!text
-    text: showFullTimestamp ? LocaleUtils.formatDateTime(timestamp) : LocaleUtils.formatRelativeTimestamp(timestamp)
+    text: d.formattedLabel
+
+    QtObject {
+        id: d
+        property string formattedLabel: root.showFullTimestamp ? LocaleUtils.formatDateTime(root.timestamp) : LocaleUtils.formatRelativeTimestamp(root.timestamp)
+
+        readonly property var _conn: Connections {
+            target: StatusSharedUpdateTimer
+            enabled: root.visible && root.timestamp && !root.showFullTimestamp
+            function onTriggered() {
+                const newFormattedLabel = LocaleUtils.formatRelativeTimestamp(root.timestamp)
+                if (newFormattedLabel !== d.formattedLabel) {
+                    d.formattedLabel = newFormattedLabel
+                }
+            }
+        }
+    }
+
     StatusToolTip {
         id: tooltip
         visible: hhandler.hovered && !!text
@@ -22,8 +39,8 @@ StatusBaseText {
         id: hhandler
         enabled: !root.showFullTimestamp
         onHoveredChanged: {
-            if(hhandler.hovered && timestamp) {
-                tooltip.text = LocaleUtils.formatDateTime(timestamp)
+            if(hhandler.hovered && root.timestamp) {
+                tooltip.text = LocaleUtils.formatDateTime(root.timestamp)
             }
         }
     }

diff --git a/ui/StatusQ/src/StatusQ/Core/StatusSharedUpdateTimer.qml b/ui/StatusQ/src/StatusQ/Core/StatusSharedUpdateTimer.qml
@@ -0,0 +1,17 @@
+pragma Singleton
+
+import QtQml 2.15
+
+QtObject {
+    id: root
+
+    signal triggered()
+
+    readonly property Timer d: Timer {
+        interval: 1000
+        running: Qt.application.state === Qt.ApplicationActive
+        repeat: true
+        triggeredOnStart: true
+        onTriggered: root.triggered()
+    }
+}
diff --git a/ui/StatusQ/src/StatusQ/Core/qmldir b/ui/StatusQ/src/StatusQ/Core/qmldir
@@ -13,5 +13,6 @@ StatusModalHeaderSettings 0.1 StatusModalHeaderSettings.qml
 StatusProfileImageSettings 0.1 StatusProfileImageSettings.qml
 StatusRollArea 0.1 StatusRollArea.qml
 StatusScrollView 0.1 StatusScrollView.qml
+singleton StatusSharedUpdateTimer 0.1 StatusSharedUpdateTimer.qml
 StatusTooltipSettings 0.1 StatusTooltipSettings.qml
 singleton LocaleUtils 0.1 LocaleUtils.qml
diff --git a/ui/StatusQ/src/statusq.qrc b/ui/StatusQ/src/statusq.qrc
@@ -170,6 +170,7 @@
         <file>StatusQ/Core/StatusModalHeaderSettings.qml</file>
         <file>StatusQ/Core/StatusProfileImageSettings.qml</file>
         <file>StatusQ/Core/StatusRollArea.qml</file>
+        <file>StatusQ/Core/StatusSharedUpdateTimer.qml</file>
         <file>StatusQ/Core/StatusScrollView.qml</file>
         <file>StatusQ/Core/StatusTooltipSettings.qml</file>
         <file>StatusQ/Core/Theme/StatusColors.qml</file>