fix: Supply amount in mint tokens preview #11439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
micieslak
approved these changes
Jul 6, 2023
| @@ -309,7 +309,7 @@ StatusScrollView { | |||
|
|
|||
| onTextChanged: { | |||
| const amount = parseInt(text) | |||
| if (Number.isNaN(amount) || !!errors) | |||
| if (Number.isNaN(amount) || (!!errors && Object.values(errors).length)) | |||
There was a problem hiding this comment.
errors seems to be always valid object, so maybe !!error check is not needed at all?
Check errors object for values before invalidating the supply amount.
alexjba
force-pushed
the
11359-wrong-supply-and-remaining-values-when-preview-collectible-before-deployment
branch
from
9ba205b
to
7531fbf
Compare
alexjba
deleted the
11359-wrong-supply-and-remaining-values-when-preview-collectible-before-deployment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Closing #11359
Check
errorsobject for values before invalidating the supply amount.Affected areas
Mint tokens
Screenshot of functionality (including design for comparison)