11129 assets burn mint #11353
Merged
11129 assets burn mint #11353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (35)
|
Closed
noeliaSD
approved these changes
Jul 3, 2023
| @@ -73,17 +74,17 @@ proc init*(self: Controller) = | |||
| proc deployContract*(self: Controller, communityId: string, addressFrom: string, password: string, deploymentParams: DeploymentParameters, tokenMetadata: CommunityTokensMetadataDto, chainId: int) = | |||
| self.communityTokensService.deployContract(communityId, addressFrom, password, deploymentParams, tokenMetadata, chainId) | |||
|
|
|||
| proc airdropCollectibles*(self: Controller, communityId: string, password: string, collectiblesAndAmounts: seq[CommunityTokenAndAmount], walletAddresses: seq[string]) = | |||
| self.communityTokensService.airdropCollectibles(communityId, password, collectiblesAndAmounts, walletAddresses) | |||
| proc airdropTokens*(self: Controller, communityId: string, password: string, collectiblesAndAmounts: seq[CommunityTokenAndAmount], walletAddresses: seq[string]) = | |||
There was a problem hiding this comment.
Suggested change
| proc airdropTokens*(self: Controller, communityId: string, password: string, collectiblesAndAmounts: seq[CommunityTokenAndAmount], walletAddresses: seq[string]) = | |
| proc airdropTokens*(self: Controller, communityId: string, password: string, tokensAndAmounts: seq[CommunityTokenAndAmount], walletAddresses: seq[string]) = |
| proc airdropCollectibles*(self: Controller, communityId: string, password: string, collectiblesAndAmounts: seq[CommunityTokenAndAmount], walletAddresses: seq[string]) = | ||
| self.communityTokensService.airdropCollectibles(communityId, password, collectiblesAndAmounts, walletAddresses) | ||
| proc airdropTokens*(self: Controller, communityId: string, password: string, collectiblesAndAmounts: seq[CommunityTokenAndAmount], walletAddresses: seq[string]) = | ||
| self.communityTokensService.airdropTokens(communityId, password, collectiblesAndAmounts, walletAddresses) |
There was a problem hiding this comment.
Suggested change
| self.communityTokensService.airdropTokens(communityId, password, collectiblesAndAmounts, walletAddresses) | |
| self.communityTokensService.airdropTokens(communityId, password, tokensAndAmounts, walletAddresses) |
| proc computeAirdropCollectiblesFee*(self: Controller, collectiblesAndAmounts: seq[CommunityTokenAndAmount], walletAddresses: seq[string]) = | ||
| self.communityTokensService.computeAirdropCollectiblesFee(collectiblesAndAmounts, walletAddresses) | ||
| proc computeAirdropFee*(self: Controller, collectiblesAndAmounts: seq[CommunityTokenAndAmount], walletAddresses: seq[string]) = | ||
| self.communityTokensService.computeAirdropFee(collectiblesAndAmounts, walletAddresses) |
There was a problem hiding this comment.
Suggested change
| self.communityTokensService.computeAirdropFee(collectiblesAndAmounts, walletAddresses) | |
| self.communityTokensService.computeAirdropFee(tokensAndAmounts, walletAddresses) |
endulab
force-pushed
the
11129-assets-burn-mint
branch
4 times, most recently
from
4dee2e6
to
5b18c36
Compare
|
According to discussion with @micieslak, the current state of this pr is fully functional, but all asset operations handle only integers. Floating points will be handled later.
Also pr need to be rebased with #11439 in order to deploy contract with >1 supply. |
endulab
force-pushed
the
11129-assets-burn-mint
branch
from
5b18c36
to
373898c
Compare
micieslak
approved these changes
Jul 7, 2023
| let tokenDto = self.controller.findContractByUniqueId(contractUniqueKey) | ||
| let amountStr = token["amount"].getFloat |
There was a problem hiding this comment.
it's float, not a string like the name suggests, right?
| else: | ||
| error "Converting amount - unknown token type", tokenType=tokenType | ||
|
|
||
| proc getTokenAndAmountList(self: Module, communityId: string, tokensJsonString: string): seq[CommunityTokenAndAmount] = |
There was a problem hiding this comment.
Whenever we take json as a string it would be nice to have short description what's the expected structure of that json :)
jrainville
approved these changes
Jul 7, 2023
|
Hey @endulab , seems like the majority of the actions are OK but sometimes are slow to be reflected in the app, or require a restart. Some further notes are below. Please let me know if you want them split out or if they will be addressed as part of this PR.
|
|
@glitchminer thank you for great testing.
Yes, let's address these issues in new tasks. This one is quite big and I want to merge it asap. |
|
@endulab Since this token is "unknown" to us (as in, it's not in the wallet's list of supported tokens), it gets by default shown as "ETH". That's being changed here #11433 to prevent confusion, so unknown ERC20 tokens will now be handled specially. What we actually need though is to make sure we add relevant tokens to the wallet's list. Something like, when you (attempt to) join a community that has deployed ERC20 contracts, you add such tokens to your supported tokens list. That way, balances, token name, transfers, etc will be displayed correctly across the app. |
glitchminer
approved these changes
Jul 11, 2023
This was referenced Jul 11, 2023
Adjst burning and minting flows to handle assets. Supplies are passed from qml to nim as strings - "2" for ERC721, "1.5" for ERC20 String amounts are converted to Uint256 type. Additionally ERC20 amounts are converted to basic units (wei-like, decimals=18). Uint256 values are passed to backend functions and then coverted to strings which can be converted to bigInt.BigInt types. Supply and RemainingSupply are exposed to qml as floats. Issue #11129
endulab
force-pushed
the
11129-assets-burn-mint
branch
from
373898c
to
520e4b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Burn and mint functionality for assets.
Adjust burning and minting flows to handle assets.
Supplies are passed from qml to nim as strings - "2" for ERC721, "1.5" for ERC20
String amounts are converted to Uint256 type. Additionally ERC20 amounts are converted to basic units (wei-like). Uint256 values are passed to backend functions and then coverted to strings which can be converted to bigInt.BigInt types.
Supply and RemainingSupply are exposed to qml as floats.
Issue #11129
It is a fully functional pr, but all operation on assets are integer-based, like with collectibles.
Please create a backup of your Status dir because the pr is doing migration.