Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update completions.rs addressing issue #5935 #6010

Closed
wants to merge 1 commit into from

Conversation

kaksv
Copy link

@kaksv kaksv commented Jul 11, 2024

Added the closing brace as required.issue #5935


This change is Reviewable

Added the closing brace as required.issue starkware-libs#5935
Copy link
Contributor

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Draggu, @kaksv, and @orizi)

a discussion (no related file):
All my comments from #5956 (review) apply here. Can you please resolve them in this PR?



crates/cairo-lang-language-server/src/ide/completion/completions.rs line 285 at r1 (raw file):

    let completion = CompletionItem {
        label: format!("{}()", name),
        insert_text: Some(format!("{}(", name))),

This is just breaking Rust code syntax, it's not fixing the issue.

@mkaput mkaput closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants