Insert right paren after cursor when completing method calls #5935

[PavitraAgarwal21]

insert a closing parenthesis after the cursor in the Cairo language server.

---

This change is 

[mkaput]

Thank you for the contribution! Don't remember to use Reviewable for answering to comments btw :)

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @PavitraAgarwal21)

a discussion (no related file):
Please add tests for this change.

We do not have any completions tests yet, but they should be pretty trivial to add because we have very similar tests for hovers already.

Hover tests are coded here:

cairo/crates/cairo-lang-language-server/tests/e2e/hover.rs

Line 11 in 00c1c18

cairo_lang_test_utils::test_file_test!(

and they are using snapshot fixtures, example one is here:

cairo/crates/cairo-lang-language-server/tests/test_data/hover/basic.txt

Line 1 in 4646ad8

//! > Hover

The test plan I imagine should look like the issue description I did, i.e. using the cursors mechanism you form a situation of the code before completion, and a situation after it. Then you run the completion request over the before snippet, apply the result and you compare what you got.

Here you have a ton of examples of such tests from IntelliJ Rust codebase: https://github.com/intellij-rust/intellij-rust/blob/c6657c02bb62075bf7b7ceb84d000f93dda34dc1/src/test/kotlin/org/rust/lang/core/completion/RsCompletionTest.kt

---

---

crates/cairo-lang-language-server/src/ide/completion/completions.rs line 285 at r1 (raw file):

    let completion = CompletionItem {
        label: format!("{}()", name),
        insert_text: Some(format!("{}()", name)),

This sounds like it always puts the cursor after ), isn't it?

Can you put the cursor before ) if the completed function has any arguments?

See this video on how it's done in RustRover:

Nagranie z ekranu 2024-07-4 o 10.53.56.mov

[mkaput]

Hey @PavitraAgarwal21! Any progress on this? May I help somehow?

[PavitraAgarwal21]

Can someone take over this task? I’m currently tied up with other work.