Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Install local bundles from config maps #244

Closed
wants to merge 41 commits into from
Closed

[Merged by Bors] - Install local bundles from config maps #244

wants to merge 41 commits into from

Conversation

razvan
Copy link
Member

@razvan razvan commented Feb 23, 2022 •
edited
Loading

Description

Fixes: https://github.com/stackabletech/regorule-operator/issues/190

Added opa-bundle-helper. An additional way to install bundles without the need of a regorule operator.

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@razvan razvan requested a review from a team February 24, 2022 07:48
@razvan razvan marked this pull request as ready for review February 24, 2022 07:48
soenkeliebau
soenkeliebau reviewed Feb 24, 2022
View reviewed changes
Copy link
Member

@soenkeliebau soenkeliebau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few random comments

docker/Dockerfile.helper Outdated Show resolved Hide resolved
rust/bundle-helper/Cargo.toml Outdated Show resolved Hide resolved
rust/bundle-helper/src/main.rs Outdated Show resolved Hide resolved
rust/bundle-helper/src/main.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/controller.rs Show resolved Hide resolved
rust/operator-binary/src/controller.rs Show resolved Hide resolved
rust/operator-binary/src/controller.rs Outdated Show resolved Hide resolved
maltesander
maltesander reviewed Feb 24, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments, could not test yet.

deploy/helm/opa-operator/templates/roles.yaml Outdated Show resolved Hide resolved
rust/bundle-helper/src/main.rs Outdated Show resolved Hide resolved
docker/Dockerfile.helper Outdated Show resolved Hide resolved
rust/operator-binary/src/controller.rs Outdated Show resolved Hide resolved
@maltesander maltesander mentioned this pull request Feb 24, 2022
Closed
2 tasks
This was referenced Feb 25, 2022
Closed
Closed
maltesander
maltesander reviewed Feb 25, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor things.

rust/bundle-builder/Cargo.toml Outdated Show resolved Hide resolved
examples/simple-rule.yaml Outdated Show resolved Hide resolved
deploy/helm/opa-operator/templates/roles.yaml Outdated Show resolved Hide resolved
@maltesander maltesander linked an issue Feb 25, 2022 that may be closed by this pull request
Support specifying a namespace to watch #235
Closed
2 tasks
maltesander
maltesander reviewed Feb 28, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor things

rust/bundle-builder/src/main.rs Show resolved Hide resolved
rust/bundle-builder/src/main.rs Show resolved Hide resolved
rust/bundle-builder/Cargo.toml Outdated Show resolved Hide resolved
maltesander
maltesander approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@razvan
Copy link
Member Author

razvan commented Feb 28, 2022

bors merge

bors bot pushed a commit that referenced this pull request Feb 28, 2022
@razvan @maltesander
Install local bundles from config maps (#244)
77c49a1 
## Description

Fixes: https://github.com/stackabletech/regorule-operator/issues/190

Added `opa-bundle-helper`. An additional way to install bundles without the need of a regorule operator.



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 28, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Install local bundles from config maps [Merged by Bors] - Install local bundles from config maps Feb 28, 2022
@bors bors bot closed this Feb 28, 2022
@bors bors bot deleted the feature/use-local-bundles branch February 28, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soenkeliebau soenkeliebau soenkeliebau left review comments

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support specifying a namespace to watch
3 participants
@razvan @soenkeliebau @maltesander