Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Adapt to opa rework and support specifying a namespace to watch #157

Closed
wants to merge 6 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Feb 25, 2022

Description

This PR addresses two issues.

OPA rework

This is a BREAKING change. It will only work with opa-operator tag 0.9.0 or higher. The regorule operator is not required anymore since OPA does the bundeling via configmaps.

Trino now writes a config maps (which are read by opa) for authorization instead of the regorule-operator custom resource.

fixes #156

Specify a namespace to watch

try

cargo run -- run --watch-namespace test

or

export WATCH_NAMESPACE=test
cargo run -- run

fixes #137

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team February 28, 2022 11:39
@maltesander maltesander marked this pull request as ready for review February 28, 2022 11:39
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Feb 28, 2022
## Description

This PR addresses two issues.

### OPA rework

This is a `BREAKING` change. It will only work with opa-operator tag `0.9.0` or higher. The regorule operator is not required anymore since OPA does the bundeling via configmaps. 

Trino now writes a config maps (which are read by opa) for authorization instead of the regorule-operator custom resource.

fixes #156

### Specify a namespace to watch

try
```
cargo run -- run --watch-namespace test
```
or
```
export WATCH_NAMESPACE=test
cargo run -- run
```

fixes #137



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 28, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Adapt to opa rework and support specifying a namespace to watch [Merged by Bors] - Adapt to opa rework and support specifying a namespace to watch Feb 28, 2022
@bors bors bot closed this Feb 28, 2022
@bors bors bot deleted the adapt_to_opa_rework branch February 28, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write rego config maps for new opa operator Support specifying a namespace to watch
2 participants