Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix verification negative tests about signature #102

Merged
merged 2 commits into from
Sep 1, 2022
Merged

fix verification negative tests about signature #102

merged 2 commits into from
Sep 1, 2022

Commits on Aug 26, 2022

  1. fix verification negative tests about signature 

    The tests "malformed signature" and "wrong signature" were actually failing because of the expiration time, which was less than `now`, and not because of the signature. This because the expiration time check is performed before the signature check. See: https://github.com/spruceid/siwe/blob/main/packages/siwe/lib/client.ts#L263-L276
    @navigatrum
    navigatrum committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    c072e13 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Fix test

    @sbihel
    sbihel committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    5599e34 View commit details
    Browse the repository at this point in the history