fix verification negative tests about signature #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests "malformed signature" and "wrong signature" were actually failing because of the expiration time, which was less than `now`, and not because of the signature. This because the expiration time check is performed before the signature check. See: https://github.com/spruceid/siwe/blob/main/packages/siwe/lib/client.ts#L263-L276
sbihel
reviewed
Aug 30, 2022
sbihel
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests "malformed signature" and "wrong signature" were actually failing because of the expiration time, which was less than
now, and not because of the signature. This because the expiration time check is performed before the signature check. See: https://github.com/spruceid/siwe/blob/main/packages/siwe/lib/client.ts#L259-L313[link edited]