Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2218 add ability to pass AdminClient #2219

Merged
merged 1 commit into from
Apr 7, 2022
Merged

GH-2218 add ability to pass AdminClient #2219

merged 1 commit into from
Apr 7, 2022

Conversation

gurpiarbassi
Copy link
Contributor

@gurpiarbassi gurpiarbassi commented Apr 7, 2022 •
edited
Loading

  • Fixes GH-2218
  • Useful when you want to pass an AdminClient that has already
    been initialised with specific properties to connect to the cluster
    e.g. SSL properties.

@gurpiarbassi
spring-projectsGH-2218 add ability to pass AdminClient
f07efe6 
- Useful when you want to pass an AdminClient that has already
been initialised with specific properties to connect to the cluster
e.g. SSL properties.
artembilan
artembilan approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not harmful and can be accepted even if KafkaTestUtils has been designed for the testing against embedded Kafka.

@garyrussell garyrussell merged commit 0278465 into spring-projects:main Apr 7, 2022
@garyrussell
Copy link
Contributor

Thanks for the contribution; merged and cherry-picked to 2.9.x, 2.8.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artembilan artembilan artembilan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KafkaTestUtils getCurrentOffset() could take a AdminClient as argument
3 participants
@gurpiarbassi @garyrussell @artembilan