Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KafkaTestUtils getCurrentOffset() could take a AdminClient as argument #2218

Closed
gurpiarbassi opened this issue Apr 7, 2022 · 0 comments · Fixed by #2219
Closed

KafkaTestUtils getCurrentOffset() could take a AdminClient as argument #2218

gurpiarbassi opened this issue Apr 7, 2022 · 0 comments · Fixed by #2219
Labels
backport 2.8.x (obsolete) backport 2.9.x (obsolete) type: enhancement

Comments

@gurpiarbassi
Copy link
Contributor

Expected Behavior

I'd like to be able to pass AdminClient as a argument to this method. That way I can initialise the AdminClient with relevant SSL properties to connect to a SSL cluster.

Current Behavior

Not able to pass SSL connection properties to AdminClient. It only uses bootstrap.servers at the moment.

Context

I cannot use this method at the moment to connect to a SSL cluster in my tests
gurpiarbassi added a commit to gurpiarbassi/spring-kafka that referenced this issue Apr 7, 2022
@gurpiarbassi
spring-projectsGH-2218 add ability to pass AdminClient
7c7f133 
- Useful when you want to pass an AdminClient that has already
been initialised with specific properties to connect to the cluster
e.g. SSL properties.
gurpiarbassi added a commit to gurpiarbassi/spring-kafka that referenced this issue Apr 7, 2022
@gurpiarbassi
spring-projectsGH-2218 add ability to pass AdminClient
f07efe6 
- Useful when you want to pass an AdminClient that has already
been initialised with specific properties to connect to the cluster
e.g. SSL properties.
@gurpiarbassi gurpiarbassi mentioned this issue Apr 7, 2022
Merged
garyrussell pushed a commit that referenced this issue Apr 7, 2022
@gurpiarbassi @garyrussell
GH-2218 add ability to pass AdminClient
0278465 
- Useful when you want to pass an AdminClient that has already
been initialised with specific properties to connect to the cluster
e.g. SSL properties.
garyrussell pushed a commit that referenced this issue Apr 7, 2022
@gurpiarbassi @garyrussell
GH-2218 add ability to pass AdminClient
7e8e378 
- Useful when you want to pass an AdminClient that has already
been initialised with specific properties to connect to the cluster
e.g. SSL properties.
garyrussell pushed a commit that referenced this issue Apr 7, 2022
@gurpiarbassi @garyrussell
GH-2218 add ability to pass AdminClient
e7db6d4 
- Useful when you want to pass an AdminClient that has already
been initialised with specific properties to connect to the cluster
e.g. SSL properties.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backport 2.8.x (obsolete) backport 2.9.x (obsolete) type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-2218 add ability to pass AdminClient gurpiarbassi/spring-kafka
2 participants
@garyrussell @gurpiarbassi