-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chassis][midplane] Add notification to Supervisor when LC is graceful reboot #3292
Conversation
…l reboot Signed-off-by: mlok <marty.lok@nokia.com>
@deepak-singhal0408 @judyjoseph This PR is for an issue of logging lost midplane connectivity log. Total 3 PRs. Please review them. Thanks |
@bmridul please help review. |
…ntry in CHASSIS_STATE_DB Signed-off-by: mlok <marty.lok@nokia.com>
@mlok-nokia , |
There should not be any functionality impact. PR #3292 just create a entry in CHASSIS_STATE_DB for platform-daemon PR sonic-net/sonic-platform-daemons#480 to use. If Platform-daemon is not in the branch, The data in DB will not be used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kenneth-arista could you review as well |
MSFT ADO: 28074312 |
…l reboot (sonic-net#3292) * [chassis][midplane] Add notification to Supervisor when LC is graceful reboot * Address review comment by adding log message when failed to create wentry in CHASSIS_STATE_DB Signed-off-by: mlok <marty.lok@nokia.com>
Cherry-pick PR to 202311: #3324 |
…l reboot (#3292) * [chassis][midplane] Add notification to Supervisor when LC is graceful reboot * Address review comment by adding log message when failed to create wentry in CHASSIS_STATE_DB Signed-off-by: mlok <marty.lok@nokia.com>
… for Nokia-IXR7250E platform (#18862) This PR add the platform specified linecard_reboot_timeout value to the platform_evn.conf. It works PR sonic-net/sonic-platform-daemons#480 and sonic-net/sonic-utilities#3292 to address issue #18540 Signed-off-by: mlok <marty.lok@nokia.com>
@StormLiangMS , no more backport allowed for 202305?? can you help review/approve/deny the backport request to 202305? |
…l reboot (sonic-net#3292) * [chassis][midplane] Add notification to Supervisor when LC is graceful reboot * Address review comment by adding log message when failed to create wentry in CHASSIS_STATE_DB Signed-off-by: mlok <marty.lok@nokia.com>
… for Nokia-IXR7250E platform (sonic-net#18862) This PR add the platform specified linecard_reboot_timeout value to the platform_evn.conf. It works PR sonic-net/sonic-platform-daemons#480 and sonic-net/sonic-utilities#3292 to address issue sonic-net#18540 Signed-off-by: mlok <marty.lok@nokia.com>
What I did
Modify the "sudo reboot" script to notify the Supervisor card by creating/inserting CHASSIS_MODULE_REBOOT_INFO_TABLE|LINE-CARD#" entry to CHASSIS_STATE_DB when reboot command is issued on the Linecard. This provides the sufficient information to allow Supervisor to log a proper message to address issue sonic-net/sonic-buildimage#18540
How I did it
Add a new function linecard_reboot_notity_supervisor() to the reboot script. If this platform is a linecard in a chassis, call sonic-db-cli to add a "CHASSIS_MODULE_REBOOT_INFO_TABLE|LINE-CARD#" to the CHASSIS_STATE_DB. This provides the information to chassisd on Supervisor card to log a proper message.
This PRs requires the following 2 PRs to address issue sonic-net/sonic-buildimage#18540 :
sonic-net/sonic-buildimage#18805
sonic-net/sonic-platform-daemons#480
sonic-net/sonic-buildimage#18862
This PR is needed by branch 202205
How to verify it
Previous command output (if the output of a command-line utility has changed)
NA
New command output (if the output of a command-line utility has changed)
NA