Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nokia][supervisor] add linecard_reboot_timeout value to platform_env.conf for Nokia-IXR7250E platform #18862

Merged
merged 1 commit into from
May 31, 2024
Merged

[Nokia][supervisor] add linecard_reboot_timeout value to platform_env.conf for Nokia-IXR7250E platform #18862

merged 1 commit into from
May 31, 2024

Conversation

mlok-nokia
Copy link
Contributor

@mlok-nokia mlok-nokia commented May 3, 2024 •
edited
Loading

Why I did it

This PR add the platform specified linecard_reboot_timeout value to the platform_evn.conf. It works PR sonic-net/sonic-platform-daemons#480 and sonic-net/sonic-utilities#3292 to address issue #18540

Work item tracking
  • Microsoft ADO (number only):

How I did it

Add line "linecard_reboot_timeout=180" to Nokia-IXR7250E Supervisor platform_env.conf file. This will allow the chassisd to derive the linecard_reboot_timeout value.

Related PRs:
sonic-net/sonic-utilities#3292
sonic-net/sonic-platform-daemons#480
#18805

How to verify it

This PR requires PRhttps://github.com/sonic-net/sonic-utilities/pull/3292 and to work with

  1. Test expected log. Use the CLI command "sudo reboot" to reboot a linecard, then check the syslog on Supervisor. The below message is logged
Apr 25 19:44:40.818378 ixre-cpm-chassis7 WARNING pmon#chassisd: Expected: Module LINE-CARD0 lost midplane connectivity
  1. Test unepxpected log. Using "sudo /sbin/reboot" or reboot a linecard with any crash method, then ccheck the syslog on Supervusor. The below message is logged.
Apr 25 19:50:22.549416 ixre-cpm-chassis7 WARNING pmon#chassisd: Unexpected: Module LINE-CARD0 lost midplane connectivity
  1. Test the expexcted reboot with timeout case. Use the CLI command "sudo reboot" on linecard. and keep it down for more than 4 minutes. The below messages are logged.
Apr 25 01:25:53.877143 ixre-cpm-chassis7 WARNING sr_device_mgr: Unable to reach slot 1 (Linecard) via Midplane
Apr 25 01:25:58.402511 ixre-cpm-chassis7 WARNING pmon#chassisd: Module LINE-CARD0 went off-line!
Apr 25 01:26:01.658959 ixre-cpm-chassis7 WARNING pmon#chassisd: Expected: Module LINE-CARD0 lost midplane connectivity.
( 3 minutes after the first log)
Apr 25 01:29:10.259527 ixre-cpm-chassis7 WARNING pmon#chassisd: Unexpected: Module LINE-CARD0 midplane connectivity is not restored in 180 seconds

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mlok-nokia
[Nokia][supervisor] add linecard_reboot_timeout value to platform_env…
f1076c7 
… for Nokia-IXR7250E platform

Signed-off-by: mlok <marty.lok@nokia.com>
@mlok-nokia
Copy link
Contributor Author

@deepak-singhal0408 Per PR sonic-net/sonic-platform-daemons#480 review comment, This PR is Platform specified data which define the linecard_reboot_timeout in platform_env.conf file for Nokia-IXR7250E platform. Please review it.

This was referenced May 3, 2024
Merged
Merged
@mlok-nokia
Copy link
Contributor Author

@deepak-singhal0408 This PR a platform specified data (linecard_reboot_timeout=180) which is associated with sonic-net/sonic-platform-daemons#480 and allow each vendor has own value. If this define is not found, the linecard_reboot_timeout will default to 180 seconds. Do we need merge this PR? I think it is good to merge it, so that other vendor can use it as example when they need to use a different value.

@deepak-singhal0408
Copy link
Contributor

@deepak-singhal0408 This PR a platform specified data (linecard_reboot_timeout=180) which is associated with sonic-net/sonic-platform-daemons#480 and allow each vendor has own value. If this define is not found, the linecard_reboot_timeout will default to 180 seconds. Do we need merge this PR? I think it is good to merge it, so that other vendor can use it as example when they need to use a different value.

yes Marty.. we need to merge this PR as well..

@deepak-singhal0408
Copy link
Contributor

/azpw run Azure.sonic-buildimage

@deepak-singhal0408
Copy link
Contributor

/azpw run

@gechiang
Copy link
Collaborator

/Azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Commenter does not have sufficient privileges for PR 18862 in repo sonic-net/sonic-buildimage

@arlakshm
Copy link
Contributor

/Azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@deepak-singhal0408
Copy link
Contributor

/Azpw run

@deepak-singhal0408
Copy link
Contributor

MSFT ADO: 28164943

@deepak-singhal0408
Copy link
Contributor

@rlhui could you please help merge? @gechiang FYI.

@rlhui rlhui self-requested a review May 31, 2024 20:48
@rlhui rlhui merged commit 510ebb0 into sonic-net:master May 31, 2024
20 checks passed
@gechiang gechiang added the Chassis for 202205 branch PRs needed for 202205 branch in msft repo label Jun 4, 2024
@gechiang
Copy link
Collaborator

gechiang commented Jun 4, 2024

MSFT ADO: 28164943

Please do not reuse ADO from different PR eventhough they are related. Each PR needs its own ADO.
Please create a new one for this one.
@deepak-singhal0408

@gechiang gechiang mentioned this pull request Jun 5, 2024
Merged
10 tasks
@gechiang gechiang added the Included in Chassis for 202205 Branch Indicate PR is already in MSFT repo 202205 branch label Jun 5, 2024
mlok-nokia added a commit to mlok-nokia/sonic-buildimage that referenced this pull request Jun 5, 2024
@mlok-nokia @gechiang
[Nokia][supervisor] add linecard_reboot_timeout value to platform_env…
056e00a 
… for Nokia-IXR7250E platform (sonic-net#18862)

This PR add the platform specified linecard_reboot_timeout value to the platform_evn.conf. It works PR sonic-net/sonic-platform-daemons#480 and sonic-net/sonic-utilities#3292 to address issue sonic-net#18540

Signed-off-by: mlok <marty.lok@nokia.com>
arun1355492 pushed a commit to arun1355492/sonic-buildimage that referenced this pull request Jul 26, 2024
@mlok-nokia @arun1355492
[Nokia][supervisor] add linecard_reboot_timeout value to platform_env…
5c52945 
… for Nokia-IXR7250E platform (sonic-net#18862)

This PR add the platform specified linecard_reboot_timeout value to the platform_evn.conf. It works PR sonic-net/sonic-platform-daemons#480 and sonic-net/sonic-utilities#3292 to address issue sonic-net#18540

Signed-off-by: mlok <marty.lok@nokia.com>
@mlok-nokia mlok-nokia deleted the nokia_linecard_reboot_timeout_value branch September 27, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlhui rlhui rlhui approved these changes

@deepak-singhal0408 deepak-singhal0408 deepak-singhal0408 approved these changes

Assignees
No one assigned
Labels
Chassis for 202205 branch PRs needed for 202205 branch in msft repo Included in Chassis for 202205 Branch Indicate PR is already in MSFT repo 202205 branch
Projects
SONiC Chassis
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mlok-nokia @deepak-singhal0408 @gechiang @arlakshm @rlhui