Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[show][config] cli refactor for muxcable with abstract class implementation from vendors (#1722) #1782

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

vdahiya12
Copy link
Contributor

@vdahiya12 vdahiya12 commented Aug 25, 2021

Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com

Merging this in 202012 branch because there was a merge conflict in original PR while cherry-picking
#1722

What I did

this PR adds support for cli refactor which is done for abstract class implementation of muxcable which is provided by vendors.
detailed design doc can be found sonic-net/SONiC#757

How I did it

Added the changes in muxcable.py in show and config .

How to verify it

add unit-tests as well as run on a Arista-7050cx3 switch, run unit tests.

no change in outputs, just the functionality has changed.

…tation from vendors (sonic-net#1722)

Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com

What I did
this PR adds support for cli refactor which is done for abstract class implementation of muxcable which is provided by vendors.
detailed design doc can be found sonic-net/SONiC#757

How I did it
Added the changes in muxcable.py in show and config .

How to verify it
add unit-tests as well as run on a Arista-7050cx3 switch, run unit tests.

no change in outputs, just the functionality has changed.
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
…tation from vendors (sonic-net#1722)

Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com

What I did
this PR adds support for cli refactor which is done for abstract class implementation of muxcable which is provided by vendors.
detailed design doc can be found sonic-net/SONiC#757

How I did it
Added the changes in muxcable.py in show and config .

How to verify it
add unit-tests as well as run on a Arista-7050cx3 switch, run unit tests.

no change in outputs, just the functionality has changed.
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
@vdahiya12
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vdahiya12 vdahiya12 merged commit be3e5c6 into sonic-net:202012 Aug 26, 2021
@vdahiya12 vdahiya12 deleted the cli branch August 26, 2021 18:55
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 18, 2022
…627)

7041400 [config reload] Call systemctl reset-failed for snmp,telemetry,mgmt-framework services (sonic-net#1773) (sonic-net#1786)
399d370 Fix logic in RIF counters print (sonic-net#1732)
8329544 [vnet_route_check] don't hardcode prefix length of /24 (sonic-net#1756)
193b028 [neighbor-advertiser] delete the tunnel maps appropriately (sonic-net#1663)
2c82bcf [neighbor_advertiser] Use existing tunnel if present for creating tunnel mappings (sonic-net#1589)
8e22960 [202012][Config] Update config command of Kdump. (sonic-net#1778)
be3e5c6 [show][config] cli refactor for muxcable with abstract class implementation from vendors (sonic-net#1722) (sonic-net#1782)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants