[show][config] cli refactor for muxcable with abstract class implementation from vendors #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implementation from vendors. Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
|
This pull request introduces 10 alerts when merging d29e556 into acb5d84 - view on LGTM.com new alerts:
|
|
This pull request introduces 7 alerts when merging 88caade into 679a4ba - view on LGTM.com new alerts:
|
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
tahmed-dev
previously approved these changes
Aug 6, 2021
| SELECT_TIMEOUT = 1000 | ||
|
|
||
| # The empty namespace refers to linux host namespace. | ||
| EMPTY_NAMESPACE = '' |
There was a problem hiding this comment.
nit: what about LINUX_HOST_NAMESPACE?
tahmed-dev
approved these changes
Aug 25, 2021
|
This commit could not be cleanly cherry-pick to 202012. Please submit another PR. |
vdahiya12
added a commit
to vdahiya12/sonic-utilities
that referenced
this pull request
Aug 25, 2021
…tation from vendors (sonic-net#1722) Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com What I did this PR adds support for cli refactor which is done for abstract class implementation of muxcable which is provided by vendors. detailed design doc can be found sonic-net/SONiC#757 How I did it Added the changes in muxcable.py in show and config . How to verify it add unit-tests as well as run on a Arista-7050cx3 switch, run unit tests. no change in outputs, just the functionality has changed. Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
vdahiya12
added a commit
to vdahiya12/sonic-utilities
that referenced
this pull request
Aug 25, 2021
…tation from vendors (sonic-net#1722) Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com What I did this PR adds support for cli refactor which is done for abstract class implementation of muxcable which is provided by vendors. detailed design doc can be found sonic-net/SONiC#757 How I did it Added the changes in muxcable.py in show and config . How to verify it add unit-tests as well as run on a Arista-7050cx3 switch, run unit tests. no change in outputs, just the functionality has changed. Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
vdahiya12
added a commit
that referenced
this pull request
Aug 26, 2021
…tation from vendors (#1722) (#1782) Merging this in 202012 branch because there was a merge conflict in original PR while cherry-picking #1722 #### What I did this PR adds support for cli refactor which is done for abstract class implementation of muxcable which is provided by vendors. detailed design doc can be found sonic-net/SONiC#757 #### How I did it Added the changes in muxcable.py in show and config . #### How to verify it add unit-tests as well as run on a Arista-7050cx3 switch, run unit tests. no change in outputs, just the logic has changed. Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
…627) 7041400 [config reload] Call systemctl reset-failed for snmp,telemetry,mgmt-framework services (sonic-net#1773) (sonic-net#1786) 399d370 Fix logic in RIF counters print (sonic-net#1732) 8329544 [vnet_route_check] don't hardcode prefix length of /24 (sonic-net#1756) 193b028 [neighbor-advertiser] delete the tunnel maps appropriately (sonic-net#1663) 2c82bcf [neighbor_advertiser] Use existing tunnel if present for creating tunnel mappings (sonic-net#1589) 8e22960 [202012][Config] Update config command of Kdump. (sonic-net#1778) be3e5c6 [show][config] cli refactor for muxcable with abstract class implementation from vendors (sonic-net#1722) (sonic-net#1782)
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
dd01491e4d167993b3a80517f737188151443a75 (HEAD -> 201911, origin/201911) [Monitor Vlan] Fix a typo in hostif (sonic-net#1722) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com
What I did
this PR adds support for cli refactor which is done for abstract class implementation of muxcable which is provided by vendors.
detailed design doc can be found sonic-net/SONiC#757
How I did it
Added the changes in muxcable.py in show and config .
How to verify it
add unit-tests as well as run on a Arista-7050cx3 switch, run unit tests.
no change in outputs, just the functionality has changed.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)