[xcvrd] Save the dom_capability of transceiver into db #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please also update sfputilbase.py |
Definitely. The PR is under reviewing. |
|
Blocked by comments on sonic-net/sonic-platform-common#102 |
|
@kuanyu99: sonic-net/sonic-platform-common#102 merged a few weeks ago. Can you please fix the merge conflicts? |
Thanks for your reminder. |
jleveque
approved these changes
Feb 24, 2021
This was referenced Mar 7, 2021
jleveque
added a commit
that referenced
this pull request
Mar 9, 2021
…'N/A' (#162) Currently, some vendors are using custom transceiver info parsers which do not yet provide the `dom_capability` field in the results of `get_transceiver_info()`. However, PR #72 introduced storing this value to State DB under the assumption that it would always be present. On platforms where this value is not present, it would cause xcvrd to crash (see issue: sonic-net/sonic-buildimage#6978). This change will prevent a crash if it is not present, and will in turn save `'N/A'` as the `dom_capability` value in State DB.
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Save the dom_capability gotten from transceiver into db
How I did it
Add a field-value pair when it try to set the table inside "post_port_sfp_info_to_db" function
How to verify it
Compare one transceiver which support diagnostic monitoring function to another transceiver which doesn't support it.
Check the db data of the transceiver
Run 'show interfaces transceiver eeprom' command.