[xcvrd] Fix crash: If 'dom_capability' not in port_info_dict, insert 'N/A' #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdahiya12
approved these changes
Mar 7, 2021
vdahiya12
added a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
… internal and nic temperature and voltage (sonic-net#162) * [sonic_y_cable] add support for retreiving firmware info for Y cable, internal and nic tempertaure and voltage This PR provides the necessary infrastructure to add support for getting firmware information running on the three ends of Y cable. Also we get internal and nic side temperature and voltage What is the motivation for this PR? To add the necessary support for fetching firmware info for Y cable, internal and nic temperature and voltage How did you do it? Added the changes in sonic-platform-common module in the y_cable.py file How did you verify/test it? opened a python shell and ran the API's manually and test verified the values are correct. Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If 'dom_capability' not in port_info_dict, insert 'N/A'
Motivation and Context
Currently, some vendors are using custom transceiver info parsers which do not yet provide the
dom_capabilityfield in the results ofget_transceiver_info(). However, PR #72 introduced storing this value to State DB under the assumption that it would always be present. On platforms where this value is not present, it would cause xcvrd to crash (see issue: sonic-net/sonic-buildimage#6978).This change will prevent a crash if it is not present, and will in turn save
'N/A'as thedom_capabilityvalue in State DB.How Has This Been Tested?
Tested on one affected platform.
Additional Information (Optional)