Updating LossyQueueVoq test for Cisco-8111 platform #9323

jsanghra · 2023-08-08T00:57:56Z

Description of PR

Updating LossyQueueVoq test for Cisco-8111 platform

What is the motivation for this PR?

Updating LossyQueueVoq test for Cisco-8111 platform

How did you verify/test it?

Verified the changes in local Cisco-8111 setup and the testcase passes .

mssonicbld · 2023-08-08T00:58:58Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing tests/saitests/py3/sai_qos_tests.py fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/saitests/py3/sai_qos_tests.py:3197:13: E128 continuation line under-indented for visual indent tests/saitests/py3/sai_qos_tests.py:3198:13: E128 continuation line under-indented for visual indent tests/saitests/py3/sai_qos_tests.py:3200:20: F821 undefined name 'get_multiple_flows' tests/saitests/py3/sai_qos_tests.py:3203:57: E231 missing whitespace after ',' ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

XuChen-MSFT · 2023-08-08T06:48:23Z

@jsanghra
can you help to resolve PR test failure?

wsycqyz · 2023-08-10T04:22:49Z

The pre-commit check is a mandatory check, please fix detected issues.

jsanghra · 2023-08-11T04:51:25Z

Sure will take a look .

XuChen-MSFT · 2023-08-28T07:12:15Z

/azp run

azure-pipelines · 2023-08-28T07:12:24Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2023-08-28T07:24:03Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing tests/saitests/py3/sai_qos_tests.py fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/saitests/py3/sai_qos_tests.py:3276:13: E128 continuation line under-indented for visual indent tests/saitests/py3/sai_qos_tests.py:3277:13: E128 continuation line under-indented for visual indent tests/saitests/py3/sai_qos_tests.py:3279:20: F821 undefined name 'get_multiple_flows' tests/saitests/py3/sai_qos_tests.py:3282:57: E231 missing whitespace after ',' ... [truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

XuChen-MSFT · 2023-08-28T13:46:54Z

@jsanghra , still have pre-commit issue. can you fix it?

fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/saitests/py3/sai_qos_tests.py:3276:13: E128 continuation line under-indented for visual indent
tests/saitests/py3/sai_qos_tests.py:3277:13: E128 continuation line under-indented for visual indent
tests/saitests/py3/sai_qos_tests.py:3279:20: F821 undefined name 'get_multiple_flows'
tests/saitests/py3/sai_qos_tests.py:3282:57: E231 missing whitespace after ','

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped
##[error]Bash exited with code '1'.
···

jsanghra · 2023-08-28T21:40:23Z

Hi Xu ,
This PR change has some dependency with changes present only on 202205 branch .
Will Sync up with @rraghav-cisco to see how that dependencies can be resolved as the change made by me is using Raghav's changes present only in 202205 branch .

XuChen-MSFT · 2023-10-19T16:34:15Z

@jsanghra pass manually test, can you help fix conflict? then we can approve and merge.

mssonicbld · 2023-10-31T19:53:28Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/saitests/py3/sai_qos_tests.py:3483:5: E303 too many blank lines (2) tests/saitests/py3/sai_qos_tests.py:3496:20: F821 undefined name 'get_multiple_flows' tests/saitests/py3/sai_qos_tests.py:3499:57: E231 missing whitespace after ',' flake8...............................................(no files to check)Skipped check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

…ghra/sonic-mgmt into lossy_queue_voq_master_8111

mssonicbld · 2023-10-31T20:16:07Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/saitests/py3/sai_qos_tests.py:3495:20: F821 undefined name 'get_multiple_flows' tests/saitests/py3/sai_qos_tests.py:3498:57: E231 missing whitespace after ',' flake8...............................................(no files to check)Skipped check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

mssonicbld · 2023-10-31T20:20:37Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/saitests/py3/sai_qos_tests.py:3495:20: F821 undefined name 'get_multiple_flows' flake8...............................................(no files to check)Skipped check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

XuChen-MSFT

looks good to me, and pass in 202305 branch

XuChen-MSFT · 2023-11-20T14:53:30Z

/azp run

azure-pipelines · 2023-11-20T14:53:40Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2023-11-20T14:54:34Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/saitests/py3/sai_qos_tests.py:15:1: F401 'ptf.testutils.simple_udp_packet' imported but unused flake8...............................................(no files to check)Skipped check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

XuChen-MSFT · 2023-11-20T15:32:21Z

@jsanghra

tests/saitests/py3/sai_qos_tests.py:15:1: F401 'ptf.testutils.simple_udp_packet' imported but unused

can you help to fix above pre-commit failur?

mssonicbld · 2023-11-21T04:18:00Z

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...........................................(no files to check)Skipped check for added large files..............................................Passed check python ast.........................................................Passed flake8...................................................................Failed - hook id: flake8 - exit code: 1 tests/saitests/py3/sai_qos_tests.py:15:1: F401 'ptf.testutils.simple_udp_packet' imported but unused flake8...............................................(no files to check)Skipped check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
docker container.
Ensure that the pre-commit package is installed:

sudo pip install pre-commit

Go to repository root folder
Install the pre-commit hooks:

pre-commit install

Use pre-commit to check staged file:

pre-commit

Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

jsanghra · 2023-11-21T04:25:44Z

Hi Xu ,
Fixed the pre-commit issue .

XuChen-MSFT

looks good to me

* Updating LossyQueueVoq test for Cisco-8111 platform * Fixing pre-commit error * fixing pre-commit issue

mssonicbld · 2023-11-22T08:57:06Z

Cherry-pick PR to 202305: #10830

XuChen-MSFT · 2023-11-22T13:28:28Z

@jsanghra
can you help to resolve pre-commit error for cherry-pick #10830

flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/saitests/py3/sai_qos_tests.py:1389:15: F821 undefined name 'simple_udp_packet'
tests/saitests/py3/sai_qos_tests.py:1400:16: F821 undefined name 'simple_udp_packet'
tests/saitests/py3/sai_qos_tests.py:1412:20: F821 undefined name 'simple_udp_packet'
tests/saitests/py3/sai_qos_tests.py:1423:20: F821 undefined name 'simple_udp_packet'
tests/saitests/py3/sai_qos_tests.py:3367:20: F821 undefined name 'get_multiple_flows'

or manually create a separate PR for 202305 branch

* Updating LossyQueueVoq test for Cisco-8111 platform * Fixing pre-commit error * fixing pre-commit issue

Updating LossyQueueVoq test for Cisco-8111 platform

bf701f1

jsanghra mentioned this pull request Aug 8, 2023

Updating LossyQueueVoq test for Cisco-8111 platform #9129

Open

XuChen-MSFT requested review from wsycqyz, jcaiMR and XuChen-MSFT August 9, 2023 16:44

Merge branch 'master' into lossy_queue_voq_master_8111

29fbad0

jsanghra added 2 commits October 31, 2023 13:08

Merge branch 'master' into lossy_queue_voq_master_8111

f9b7481

Merge branch 'lossy_queue_voq_master_8111' of https://github.com/jsan…

1f17413

…ghra/sonic-mgmt into lossy_queue_voq_master_8111

Fixing pre-commit error

7c1337c

XuChen-MSFT previously approved these changes Nov 20, 2023

View reviewed changes

XuChen-MSFT added the Request for 202305 branch label Nov 20, 2023

Merge branch 'master' into lossy_queue_voq_master_8111

5af9bd2

fixing pre-commit issue

0f540c3

jsanghra dismissed XuChen-MSFT’s stale review via 0f540c3 November 21, 2023 04:20

XuChen-MSFT approved these changes Nov 21, 2023

View reviewed changes

XuChen-MSFT merged commit 3e7561f into sonic-net:master Nov 21, 2023
13 checks passed

StormLiangMS added the Approved for 202305 branch label Nov 22, 2023

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Nov 22, 2023

Updating LossyQueueVoq test for Cisco-8111 platform (sonic-net#9323)

6110720

* Updating LossyQueueVoq test for Cisco-8111 platform * Fixing pre-commit error * fixing pre-commit issue

mssonicbld added the Created PR to 202305 branch label Nov 22, 2023

mssonicbld mentioned this pull request Nov 22, 2023

[action] [PR:9323] Updating LossyQueueVoq test for Cisco-8111 platform #10830

Merged

mssonicbld pushed a commit that referenced this pull request Dec 18, 2023

Updating LossyQueueVoq test for Cisco-8111 platform (#9323)

738dee2

* Updating LossyQueueVoq test for Cisco-8111 platform * Fixing pre-commit error * fixing pre-commit issue

mssonicbld added Included in 202305 branch and removed Created PR to 202305 branch labels Dec 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating LossyQueueVoq test for Cisco-8111 platform #9323

Updating LossyQueueVoq test for Cisco-8111 platform #9323

jsanghra commented Aug 8, 2023

mssonicbld commented Aug 8, 2023

XuChen-MSFT commented Aug 8, 2023

wsycqyz commented Aug 10, 2023

jsanghra commented Aug 11, 2023

XuChen-MSFT commented Aug 28, 2023

azure-pipelines bot commented Aug 28, 2023

mssonicbld commented Aug 28, 2023

XuChen-MSFT commented Aug 28, 2023

jsanghra commented Aug 28, 2023

XuChen-MSFT commented Oct 19, 2023

mssonicbld commented Oct 31, 2023

mssonicbld commented Oct 31, 2023

mssonicbld commented Oct 31, 2023

XuChen-MSFT left a comment

XuChen-MSFT commented Nov 20, 2023

azure-pipelines bot commented Nov 20, 2023

mssonicbld commented Nov 20, 2023

XuChen-MSFT commented Nov 20, 2023

mssonicbld commented Nov 21, 2023

jsanghra commented Nov 21, 2023

XuChen-MSFT left a comment

mssonicbld commented Nov 22, 2023

XuChen-MSFT commented Nov 22, 2023 •

edited

Loading

Updating LossyQueueVoq test for Cisco-8111 platform #9323

Updating LossyQueueVoq test for Cisco-8111 platform #9323

Conversation

jsanghra commented Aug 8, 2023

Description of PR

What is the motivation for this PR?

How did you verify/test it?

mssonicbld commented Aug 8, 2023

XuChen-MSFT commented Aug 8, 2023

wsycqyz commented Aug 10, 2023

jsanghra commented Aug 11, 2023

XuChen-MSFT commented Aug 28, 2023

azure-pipelines bot commented Aug 28, 2023

mssonicbld commented Aug 28, 2023

XuChen-MSFT commented Aug 28, 2023

jsanghra commented Aug 28, 2023

XuChen-MSFT commented Oct 19, 2023

mssonicbld commented Oct 31, 2023

mssonicbld commented Oct 31, 2023

mssonicbld commented Oct 31, 2023

XuChen-MSFT left a comment

Choose a reason for hiding this comment

XuChen-MSFT commented Nov 20, 2023

azure-pipelines bot commented Nov 20, 2023

mssonicbld commented Nov 20, 2023

XuChen-MSFT commented Nov 20, 2023

mssonicbld commented Nov 21, 2023

jsanghra commented Nov 21, 2023

XuChen-MSFT left a comment

Choose a reason for hiding this comment

mssonicbld commented Nov 22, 2023

XuChen-MSFT commented Nov 22, 2023 • edited Loading

XuChen-MSFT commented Nov 22, 2023 •

edited

Loading