Updating LossyQueueVoq test for Cisco-8111 platform #9129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevinskwang @yxieca can you please review / merge? |
XuChen-MSFT
suggested changes
Aug 7, 2023
There was a problem hiding this comment.
@jsanghra, could you commit to master branch first to make sure PR test pass?
|
Raised a PR on Master branch : |
XuChen-MSFT
reviewed
Sep 18, 2023
tests/saitests/py3/sai_qos_tests.py
Outdated
| @@ -3343,28 +3340,25 @@ def runTest(self): | |||
| assert diff > 0, "Failed to cause TX drop on port {}".format(self.dst_port_id) | |||
| xmit_counters_base = xmit_counters | |||
| # Find a separate flow that uses alternate queue | |||
| max_iters = 50 | |||
| for i in range(max_iters): | |||
| for index, (second_pkt, _) in enumerate(pkt_list): | |||
There was a problem hiding this comment.
syntax error, after apply this line to latest 202205:
======================================================================
ERROR: sai_qos_tests.LossyQueueVoqTest
----------------------------------------------------------------------
Traceback (most recent call last):
File \"saitests/py3/sai_qos_tests.py\", line 3378, in runTest
for index, (second_pkt, _) in enumerate(pkt_list):
ValueError: too many values to unpack (expected 2)
There was a problem hiding this comment.
Hi ,
The recent merge of PR9362 in 202205 branch caused this error , I have updated this PR to fix that issue .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Updating LossyQueueVoq test for Cisco-8111 platform
What is the motivation for this PR?
Updating LossyQueueVoq test for Cisco-8111 platform
How did you verify/test it?
Verified the changes in local Cisco-8111 setup and the testcase passes .