Add 2 parameters for driver tg3 can support "short preamble" and "reset". #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: roy_lee <roy_lee@accton.com>
lguohan
reviewed
Nov 29, 2018
| tp->mi_mode &= ~MAC_MI_MODE_AUTO_POLL; | ||
| + | ||
| + if(short_preamble) { | ||
| + netdev_info(tp->dev, "Setting short preamble..."); |
There was a problem hiding this comment.
should remove this, it is debug level info.
lguohan
reviewed
Nov 29, 2018
| } | ||
|
|
||
| + if (bcm5718s_reset && tp->phy_id == TG3_PHY_ID_BCM5718S) { | ||
| + netdev_info(tp->dev, "BCM5718S reset..."); |
There was a problem hiding this comment.
should remove this, it is debug level info.
Signed-off-by: roy_lee <roy_lee@accton.com>
Signed-off-by: roy_lee <roy_lee@accton.com>
|
I've removed these 2 debug messages and verified. |
lguohan
approved these changes
Nov 29, 2018
kuba-moo
pushed a commit
to linux-netdev/testing
that referenced
this pull request
Aug 2, 2024
Add parameter to enable *short preamble* for MAC, so MDIO access to some
external PHY, like BCM54616, can be validated.
Applies to the five platforms below, that have the ethernet controller
BCM5720:
as7116_54x, as7326_56x, as7716_32x-r0, as7716_32xb, and as7816_64x
Verified by mii-tool. (31 is the address of external phy).
root@sonic:/home/admin# mii-tool -v eth0 -p 31
using the specified MII index 31.
eth0: negotiated, link ok
product info: vendor 00:d8:97, model 17 rev 2
basic mode: autonegotiation enabled
basic status: autonegotiation complete, link ok
capabilities: 1000baseT-HD 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
advertising: flow-control
link partner: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
Note, this upstreams a patch to the SONiC Linux kernel added in 2018
[1][2][3].
[1]: sonic-net/sonic-linux-kernel#71
[2]: sonic-net/sonic-linux-kernel@ad754bd
[3]: sonic-net/sonic-buildimage#2318
Signed-off-by: Roy Lee <roy_lee@accton.com>
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Signed-off-by: NipaLocal <nipa@local>
kuba-moo
pushed a commit
to linux-netdev/testing
that referenced
this pull request
Aug 2, 2024
Add parameter to enable *short preamble* for MAC, so MDIO access to some
external PHY, like BCM54616, can be validated.
Applies to the five platforms below, that have the ethernet controller
BCM5720:
as7116_54x, as7326_56x, as7716_32x-r0, as7716_32xb, and as7816_64x
Verified by mii-tool. (31 is the address of external phy).
root@sonic:/home/admin# mii-tool -v eth0 -p 31
using the specified MII index 31.
eth0: negotiated, link ok
product info: vendor 00:d8:97, model 17 rev 2
basic mode: autonegotiation enabled
basic status: autonegotiation complete, link ok
capabilities: 1000baseT-HD 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
advertising: flow-control
link partner: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
Note, this upstreams a patch to the SONiC Linux kernel added in 2018
[1][2][3].
[1]: sonic-net/sonic-linux-kernel#71
[2]: sonic-net/sonic-linux-kernel@ad754bd
[3]: sonic-net/sonic-buildimage#2318
Signed-off-by: Roy Lee <roy_lee@accton.com>
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Signed-off-by: NipaLocal <nipa@local>
kuba-moo
pushed a commit
to linux-netdev/testing
that referenced
this pull request
Aug 2, 2024
Add parameter to enable *short preamble* for MAC, so MDIO access to some
external PHY, like BCM54616, can be validated.
Applies to the five platforms below, that have the ethernet controller
BCM5720:
as7116_54x, as7326_56x, as7716_32x-r0, as7716_32xb, and as7816_64x
Verified by mii-tool. (31 is the address of external phy).
root@sonic:/home/admin# mii-tool -v eth0 -p 31
using the specified MII index 31.
eth0: negotiated, link ok
product info: vendor 00:d8:97, model 17 rev 2
basic mode: autonegotiation enabled
basic status: autonegotiation complete, link ok
capabilities: 1000baseT-HD 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
advertising: flow-control
link partner: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
Note, this upstreams a patch to the SONiC Linux kernel added in 2018
[1][2][3].
[1]: sonic-net/sonic-linux-kernel#71
[2]: sonic-net/sonic-linux-kernel@ad754bd
[3]: sonic-net/sonic-buildimage#2318
Signed-off-by: Roy Lee <roy_lee@accton.com>
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Signed-off-by: NipaLocal <nipa@local>
kuba-moo
pushed a commit
to linux-netdev/testing
that referenced
this pull request
Aug 2, 2024
Add parameter to enable *short preamble* for MAC, so MDIO access to some
external PHY, like BCM54616, can be validated.
Applies to the five platforms below, that have the ethernet controller
BCM5720:
as7116_54x, as7326_56x, as7716_32x-r0, as7716_32xb, and as7816_64x
Verified by mii-tool. (31 is the address of external phy).
root@sonic:/home/admin# mii-tool -v eth0 -p 31
using the specified MII index 31.
eth0: negotiated, link ok
product info: vendor 00:d8:97, model 17 rev 2
basic mode: autonegotiation enabled
basic status: autonegotiation complete, link ok
capabilities: 1000baseT-HD 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
advertising: flow-control
link partner: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
Note, this upstreams a patch to the SONiC Linux kernel added in 2018
[1][2][3].
[1]: sonic-net/sonic-linux-kernel#71
[2]: sonic-net/sonic-linux-kernel@ad754bd
[3]: sonic-net/sonic-buildimage#2318
Signed-off-by: Roy Lee <roy_lee@accton.com>
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Signed-off-by: NipaLocal <nipa@local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "short preamble" parameter for MAC can validate mdio access to some external PHY.
Add "reset" parameter for MAC to reset PHY at driver starting up.
Signed-off-by: roy_lee roy_lee@accton.com