Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Platform] [Accton] Validate mii-tool access on management port. #2318

Merged
merged 3 commits into from
Dec 4, 2018
Merged

[Platform] [Accton] Validate mii-tool access on management port. #2318

merged 3 commits into from
Dec 4, 2018

Conversation

roylee123
Copy link
Collaborator

Add 2 kernel cmdline, tg3.short_preamble=1 tg3.bcm5718s_reset=1, to validate mdio acccess to external PHY.
For some accton platforms are equipped BCM5720 as MAC chip of their management port.
Change kernel driver, tg3, to support "short preamble" feature of BCM5720.

These change needs also kernel patching, sonic-net/sonic-linux-kernel#71.

Signed-off-by: roy_lee roy_lee@accton.com

- What I did
Bring kernel cmdline to support short_preamble and bcm5718s_reset.
For accton platforms with ethernet controller, BCM5720.

Total 5 platforms:
as7116_54x, as7326_56x, as7716_32x-r0, as7716_32xb, and as7816_64x.

- How I did it
Add extra kernel cmdline to installer.conf on these platforms.

- How to verify it
Verified by mii-tool. (31 is the address of external phy).

root@sonic:/home/admin# mii-tool -v eth0 -p 31
using the specified MII index 31.
eth0: negotiated, link ok
product info: vendor 00:d8:97, model 17 rev 2
basic mode: autonegotiation enabled
basic status: autonegotiation complete, link ok
capabilities: 1000baseT-HD 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
advertising: flow-control
link partner: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD

@roylee123
Add kernel cmdline, tg3.short_preamble=1 tg3.bcm5718s_reset=1, to val…
6a8e93d 
…idate mdio to external PHY.

Signed-off-by: roy_lee <roy_lee@accton.com>
@lguohan
Copy link
Collaborator

lguohan commented Nov 29, 2018

I have comments on the other PR.

@lguohan
Copy link
Collaborator

lguohan commented Dec 1, 2018

@roylee123 , can you update the kernel submodule in this PR?

@roylee123
Push submodule, sonic-linux-kernel, to patch of tg3 short_preamble.
25992bf 
Signed-off-by: roy_lee <roy_lee@accton.com>
@roylee123
Copy link
Collaborator Author

Hi, I've updated the kernel submodule.
If I have to make the same change of this PR to branch 201807, should I sent another PR for it?
Or you will merge this PR to 201807?

lguohan
lguohan reviewed Dec 3, 2018
View reviewed changes
device/accton/x86_64-accton_as7116_54x-r0/installer.conf Outdated
ONIE_PLATFORM_EXTRA_CMDLINE_LINUX="pci=noaer"
ONIE_PLATFORM_EXTRA_CMDLINE_LINUX="tg3.short_preamble=1 tg3.bcm5718s_reset=1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should you just have one ONIE_PLATFORM_EXTRA_CMDLINE_LINUX? Are they conflicting to each other?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lguohan, you are right. This platform is not even maintained by Accton.
I should restore it back.

@roylee123
Restore to former version, for this platform is not maintained by Acc…
edbe9e3 
…ton.

Signed-off-by: roy_lee <roy_lee@accton.com>
@lguohan lguohan merged commit ae82c07 into sonic-net:master Dec 4, 2018
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Jun 9, 2022
@yxieca
[202205][linkmgrd][sairedis] advance submodule head
848a45c 
linkmgrd:
* 2da783b 2022-06-07 | Check self's mux mode before switching peer to standby & add support for `detach` mode (sonic-net#79) (HEAD -> 202205, github/202205) [Jing Zhang]

sairedis:
* 54642c7 2022-06-09 | [counter] Fix port flex counter  (sonic-net#1052) (HEAD -> 202205, github/202205) [Junhua Zhai]
* b7f5f92 2022-06-06 | [ci] Paralize azure pipeline  (sonic-net#1054) [Shilong Liu]

swss:
* 77043fb 2022-06-09 | [fpmsyncd] don't manipulate route weight (sonic-net#2321) (HEAD -> 202205, github/202205) [Ying Xie]
* ae157f1 2022-06-10 | Fix test_warm_reboot issues blocking PR merge (sonic-net#2309) (sonic-net#2318) [Shilong Liu]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca yxieca mentioned this pull request Jun 9, 2022
Merged
yxieca added a commit that referenced this pull request Jun 10, 2022
@yxieca
[202205][linkmgrd][sairedis] advance submodule head (#11091)
c7d8f51 
linkmgrd:
* 2da783b 2022-06-07 | Check self's mux mode before switching peer to standby & add support for `detach` mode (#79) (HEAD -> 202205, github/202205) [Jing Zhang]

sairedis:
* 54642c7 2022-06-09 | [counter] Fix port flex counter  (#1052) (HEAD -> 202205, github/202205) [Junhua Zhai]
* b7f5f92 2022-06-06 | [ci] Paralize azure pipeline  (#1054) [Shilong Liu]

swss:
* 77043fb 2022-06-09 | [fpmsyncd] don't manipulate route weight (#2321) (HEAD -> 202205, github/202205) [Ying Xie]
* ae157f1 2022-06-10 | Fix test_warm_reboot issues blocking PR merge (#2309) (#2318) [Shilong Liu]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
robertvolkmann pushed a commit to robertvolkmann/sonic-buildimage that referenced this pull request Jul 26, 2022
@yxieca @robertvolkmann
[202205][linkmgrd][sairedis] advance submodule head (sonic-net#11091)
ea34d59 
linkmgrd:
* 2da783b 2022-06-07 | Check self's mux mode before switching peer to standby & add support for `detach` mode (sonic-net#79) (HEAD -> 202205, github/202205) [Jing Zhang]

sairedis:
* 54642c7 2022-06-09 | [counter] Fix port flex counter  (sonic-net#1052) (HEAD -> 202205, github/202205) [Junhua Zhai]
* b7f5f92 2022-06-06 | [ci] Paralize azure pipeline  (sonic-net#1054) [Shilong Liu]

swss:
* 77043fb 2022-06-09 | [fpmsyncd] don't manipulate route weight (sonic-net#2321) (HEAD -> 202205, github/202205) [Ying Xie]
* ae157f1 2022-06-10 | Fix test_warm_reboot issues blocking PR merge (sonic-net#2309) (sonic-net#2318) [Shilong Liu]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kuba-moo pushed a commit to linux-netdev/testing that referenced this pull request Aug 2, 2024
@roylee123
tg3: Add param short_preamble to enable MDIO traffic to external PHYs
78eb092 
Add parameter to enable *short preamble* for MAC, so MDIO access to some
external PHY, like BCM54616, can be validated.

Applies to the five platforms below, that have the ethernet controller
BCM5720:

as7116_54x, as7326_56x, as7716_32x-r0, as7716_32xb, and as7816_64x

Verified by mii-tool. (31 is the address of external phy).

    root@sonic:/home/admin# mii-tool -v eth0 -p 31
    using the specified MII index 31.
    eth0: negotiated, link ok
    product info: vendor 00:d8:97, model 17 rev 2
    basic mode: autonegotiation enabled
    basic status: autonegotiation complete, link ok
    capabilities: 1000baseT-HD 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
    advertising: flow-control
    link partner: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD

Note, this upstreams a patch to the SONiC Linux kernel added in 2018
[1][2][3].

[1]: sonic-net/sonic-linux-kernel#71
[2]: sonic-net/sonic-linux-kernel@ad754bd
[3]: sonic-net/sonic-buildimage#2318

Signed-off-by: Roy Lee <roy_lee@accton.com>
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Signed-off-by: NipaLocal <nipa@local>
kuba-moo pushed a commit to linux-netdev/testing that referenced this pull request Aug 2, 2024
@roylee123
tg3: Add param short_preamble to enable MDIO traffic to external PHYs
8d9eddd 
Add parameter to enable *short preamble* for MAC, so MDIO access to some
external PHY, like BCM54616, can be validated.

Applies to the five platforms below, that have the ethernet controller
BCM5720:

as7116_54x, as7326_56x, as7716_32x-r0, as7716_32xb, and as7816_64x

Verified by mii-tool. (31 is the address of external phy).

    root@sonic:/home/admin# mii-tool -v eth0 -p 31
    using the specified MII index 31.
    eth0: negotiated, link ok
    product info: vendor 00:d8:97, model 17 rev 2
    basic mode: autonegotiation enabled
    basic status: autonegotiation complete, link ok
    capabilities: 1000baseT-HD 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
    advertising: flow-control
    link partner: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD

Note, this upstreams a patch to the SONiC Linux kernel added in 2018
[1][2][3].

[1]: sonic-net/sonic-linux-kernel#71
[2]: sonic-net/sonic-linux-kernel@ad754bd
[3]: sonic-net/sonic-buildimage#2318

Signed-off-by: Roy Lee <roy_lee@accton.com>
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Signed-off-by: NipaLocal <nipa@local>
kuba-moo pushed a commit to linux-netdev/testing that referenced this pull request Aug 2, 2024
@roylee123
tg3: Add param short_preamble to enable MDIO traffic to external PHYs
e07809f 
Add parameter to enable *short preamble* for MAC, so MDIO access to some
external PHY, like BCM54616, can be validated.

Applies to the five platforms below, that have the ethernet controller
BCM5720:

as7116_54x, as7326_56x, as7716_32x-r0, as7716_32xb, and as7816_64x

Verified by mii-tool. (31 is the address of external phy).

    root@sonic:/home/admin# mii-tool -v eth0 -p 31
    using the specified MII index 31.
    eth0: negotiated, link ok
    product info: vendor 00:d8:97, model 17 rev 2
    basic mode: autonegotiation enabled
    basic status: autonegotiation complete, link ok
    capabilities: 1000baseT-HD 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
    advertising: flow-control
    link partner: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD

Note, this upstreams a patch to the SONiC Linux kernel added in 2018
[1][2][3].

[1]: sonic-net/sonic-linux-kernel#71
[2]: sonic-net/sonic-linux-kernel@ad754bd
[3]: sonic-net/sonic-buildimage#2318

Signed-off-by: Roy Lee <roy_lee@accton.com>
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Signed-off-by: NipaLocal <nipa@local>
kuba-moo pushed a commit to linux-netdev/testing that referenced this pull request Aug 2, 2024
@roylee123
tg3: Add param short_preamble to enable MDIO traffic to external PHYs
b02a553 
Add parameter to enable *short preamble* for MAC, so MDIO access to some
external PHY, like BCM54616, can be validated.

Applies to the five platforms below, that have the ethernet controller
BCM5720:

as7116_54x, as7326_56x, as7716_32x-r0, as7716_32xb, and as7816_64x

Verified by mii-tool. (31 is the address of external phy).

    root@sonic:/home/admin# mii-tool -v eth0 -p 31
    using the specified MII index 31.
    eth0: negotiated, link ok
    product info: vendor 00:d8:97, model 17 rev 2
    basic mode: autonegotiation enabled
    basic status: autonegotiation complete, link ok
    capabilities: 1000baseT-HD 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
    advertising: flow-control
    link partner: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD

Note, this upstreams a patch to the SONiC Linux kernel added in 2018
[1][2][3].

[1]: sonic-net/sonic-linux-kernel#71
[2]: sonic-net/sonic-linux-kernel@ad754bd
[3]: sonic-net/sonic-buildimage#2318

Signed-off-by: Roy Lee <roy_lee@accton.com>
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Signed-off-by: NipaLocal <nipa@local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

Assignees
No one assigned
Labels
Enhancement ➕ Platform: Accton
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roylee123 @lguohan @stcheng