Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Edgecore][AS7726/PDDF] Enhance sonic_platform feature #12993

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

jostar-yang
Copy link
Contributor

@jostar-yang jostar-yang commented Dec 8, 2022

Signed-off-by: jostar-yang jostar_yang@edge-core.com

Why I did it

  1. Support show system-health on pddf platform
  2. Base on Adding PDDF common framework enhancements. #12863 and needed code to pass pytest.
  3. show platfomr pcieinfo will not show error message

How I did it

Add needed code to pddf and sonic_platform.

How to verify it

Test show cmd.
root@sonic:/home/admin# show platform fan
Drawer LED FAN Speed Direction Presence Status Timestamp


Fantray1 green Fantray1_1 52% EXHAUST Present OK 20220922 14:34:28
Fantray1 green Fantray1_2 52% EXHAUST Present OK 20220922 14:34:28
Fantray2 green Fantray2_1 52% EXHAUST Present OK 20220922 14:34:28
Fantray2 green Fantray2_2 52% EXHAUST Present OK 20220922 14:34:28
Fantray3 green Fantray3_1 52% EXHAUST Present OK 20220922 14:34:28
Fantray3 green Fantray3_2 52% EXHAUST Present OK 20220922 14:34:28
Fantray4 green Fantray4_1 52% EXHAUST Present OK 20220922 14:34:28
Fantray4 green Fantray4_2 52% EXHAUST Present OK 20220922 14:34:28
N/A green PSU1_FAN1 37% exhaust Present OK 20220922 14:34:28
N/A green PSU2_FAN1 36% exhaust Present OK 20220922 14:34:28

show platform temp
Sensor Temperature High TH Low TH Crit High TH Crit Low TH Warning Timestamp


  CpuBoard_temp(0x4B)           30.5       80.0       N/A             N/A            N/A      False  20220922 14:34:28
      FB_1_temp(0x4D)           31         80.0       N/A             N/A            N/A      False  20220922 14:34:28
      FB_2_temp(0x4E)           31         80.0       N/A             N/A            N/A      False  20220922 14:34:28
    MB_MAC_temp(0x48)           36         80.0       N/A             N/A            N/A      False  20220922 14:34:28

MB_RearCenter_temp(0x49) 39.5 80.0 N/A N/A N/A False 20220922 14:34:28
MB_RightCenter_temp(0x4A) 29 80.0 N/A N/A N/A False 20220922 14:34:28
PSU1_TEMP1 29 N/A N/A N/A N/A False 20220922 14:34:28
PSU2_TEMP1 29 N/A N/A N/A N/A False 20220922 14:34:28

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: jostar-yang <jostar_yang@edge-core.com>
@lgtm-com
Copy link

lgtm-com bot commented Dec 8, 2022

This pull request introduces 2 alerts when merging 9afd8ce into 7db2725 - view on LGTM.com

new alerts:

  • 2 for Unused import

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

Copy link
Contributor

@FuzailBrcm FuzailBrcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls resolve the LGTM alerts. Other changes look good to me

FuzailBrcm
FuzailBrcm previously approved these changes Dec 9, 2022
Copy link
Contributor

@FuzailBrcm FuzailBrcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are fine

@jostar-yang
Copy link
Contributor Author

jostar-yang commented Feb 14, 2023

Modify sys_led define. Refer to below PDDF framework PR,
#13475
#13476
#13477
#13474

@tobzsc
Copy link

tobzsc commented Mar 17, 2023

When will this PR be merged?

@jostar-yang
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@jostar-yang
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lguohan lguohan added the device label Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants