Adding PDDF common framework enhancements. #12863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…read functions in a PSU driver on the basis of byte, word or block read, 2) Enhancing PDDF parsing script support for CPU and PCH temperature reading, 3) Adding missing methods in PDDF common APIs
|
@jostar-yang @geans-pin @adyeung |
|
This pull request introduces 1 alert when merging e689a77 into c16b8db - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
|
Can you add "self.fans_psu_index+1" to get_position_in_parent() on pddf_fan.py for psu-fan case? |
That would be wrong. fan_index represents the actual index of the fan be it in fan_drawer or PSU. |
geans-pin
approved these changes
Dec 6, 2022
This was referenced Dec 8, 2022
lguohan
approved these changes
Dec 17, 2022
8 tasks
This was referenced Mar 14, 2023
qnos
pushed a commit
to qnos/sonic-buildimage
that referenced
this pull request
Nov 12, 2023
- Consolidating multiple read functions in a PSU driver on the basis of byte, word or block read, - Enhancing PDDF parsing script support for CPU and PCH temperature reading, - Adding missing methods in PDDF common APIs Why I did it - PSU driver changes are to optimize the code and increase the code coverage - PDDF parser script enhancements to accommodate the CPU and PCH temp reading using hwmon device path - Some of the new APIs were missing from the PDDF common platform classes How I did it Added code changes and verified them on AS7816 adn AS7726 platforms.
7 tasks
8 tasks
MuLinForest
pushed a commit
to MuLinForest/sonic-buildimage
that referenced
this pull request
Aug 6, 2024
…platform feature sonic-net#14361 Why I did it Base on Adding PDDF common framework enhancements. sonic-net#12863 to modify pddf-device.json and platform API. Add code to pass pytest. How I did it Add needed code to sonic_platform and driver. How to verify it sonic-cli cmd: show platform {fan, temperature, firmware status, syseeprom, psustatus} sfputil cmd: show {presence, eeprom, lpmode} Verify function by sonic-mgmt tools: Test file path: /tests/platform_tests/api/ Test items: test_chassis.py, test_component.py, test_fan_drawer.py, test_psu.py, test_thermal.py, test_sfp.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
How I did it
Added code changes and verified them on AS7816 adn AS7726 platforms.
How to verify it
AS7816
AS7726
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)