two platforms supporting S3IP SYSFS (TCS8400, TCS9400) #12386
Conversation
Signed-off-by: tianshangfei <tian_shangfei@163.com>
|
This pull request introduces 54 alerts when merging e96961d into 7087763 - view on LGTM.com new alerts:
|
| @@ -0,0 +1,63 @@ | |||
| <DeviceMiniGraph xmlns:i="http://www.w3.org/2001/XMLSchema-instance" xmlns="Microsoft.Search.Autopilot.Evolution"> | |||
There was a problem hiding this comment.
please remove minigraph, no longer used.
There was a problem hiding this comment.
ok，I'll update the code
There was a problem hiding this comment.
The code has been updated
Signed-off-by: tianshangfei <tian_shangfei@163.com>
|
This pull request introduces 41 alerts when merging 85c5344 into 3587489 - view on LGTM.com new alerts:
|
|
@FuzailBrcm pls help review |
device/tencent/x86_64-tencent_tcs8400-r0/TCS8400-24CC8CD/port_config.ini
Outdated
Show resolved
Hide resolved
Signed-off-by: tianshangfei <tian_shangfei@163.com>
|
This pull request introduces 42 alerts when merging cfbb047 into 5281f6c - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
|
@tianshangfei could you fix LGTM alert? |
It's been cleaned up once. Some of them are false positives. I'll go over them again |
I have checked again, LGTM Alerts are divided into two situations
See attachment for details. |
| @@ -0,0 +1,168 @@ | |||
| #!/usr/bin/env python3 | |||
| # -*- coding: UTF-8 -*- | |||
There was a problem hiding this comment.
not sure why we need to declare since UTF-8 is the default source encoding:-https://peps.python.org/pep-3120/ for Python3
There was a problem hiding this comment.
This is redundant code and has been removed，thandks
Signed-off-by: tianshangfei <tian_shangfei@163.com>
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Why I did it Add two platform that support s3IP framework How I did it Add two platforms supporting S3IP SYSFS (TCS8400, TCS9400) How to verify it Manual test
|
Cherry-pick PR to 202211: #13210 |
Why I did it Add two platform that support s3IP framework How I did it Add two platforms supporting S3IP SYSFS (TCS8400, TCS9400) How to verify it Manual test Co-authored-by: tianshangfei <31125751+tianshangfei@users.noreply.github.com>
mssonicbld
added
Included in 202211 Branch
and removed
Approved for 202211 Branch
Created PR to 202211 Branch
labels
Why I did it
Add two platform that support s3IP framework
How I did it
Add two platforms supporting S3IP SYSFS (TCS8400, TCS9400)
How to verify it
Manual test
Which release branch to backport (provide reason below if selected)
A demo driver base on s3ip framework will display the sysfs node which conforms to the s3ip sysfs specification
Description for the changelog
two platforms supporting S3IP SYSFS (TCS8400, TCS9400)
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)