[BFN] Refactoring and adding some functions of Thermal class (set and get thresholds and etc.) #10205

VadymYashchenko · 2022-03-10T11:56:45Z

Why I did it

I revise functions for correct working

How I did it

I added default_shresholds.json file and refactor and added functions for correct work with thresholds

How to verify it

I verified it with thermal tests on Newport device

Description for the changelog

Refactoring and adding some functions of Thermal class (set and get thresholds and etc.)

12 Jan update

Merge from Azure to VY

Update 2_2_2022

lgtm-com · 2022-03-14T12:25:18Z

This pull request introduces 1 alert when merging a55320c8bd7d55441809e8b1f510ad7130a75b15 into 2919b48 - view on LGTM.com

new alerts:

1 for Except block handles 'BaseException'

lgtm-com · 2022-03-14T15:02:46Z

This pull request introduces 1 alert when merging 5253e46d019e7a96dd9b14946d6c5371083eb9d8 into 2919b48 - view on LGTM.com

new alerts:

1 for Except block handles 'BaseException'

lgtm-com · 2022-03-15T15:38:16Z

This pull request introduces 1 alert when merging 5f8bdc5b8ed064026221fe773e9d008dd5243a57 into d08add5 - view on LGTM.com

new alerts:

1 for Except block handles 'BaseException'

lgtm-com · 2022-03-16T10:27:50Z

This pull request introduces 1 alert when merging f3f1b5039d927adb7f881c5ad65f75bc49cc2934 into c5849c9 - view on LGTM.com

new alerts:

1 for Except block handles 'BaseException'

lgtm-com · 2022-03-16T11:44:22Z

This pull request introduces 2 alerts when merging c597f1b6e39a65a3cd18c28b5eb5d81a5a8d6c32 into c5849c9 - view on LGTM.com

new alerts:

1 for Unreachable 'except' block
1 for Except block handles 'BaseException'

Rebase master

…al.py Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

thermal.py Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

…eshold Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

VadymYashchenko · 2022-03-22T12:56:28Z

@lguohan , @sujinmkang , @prgeor and @vdahiya12 could you make review of this merge request?

VadymYashchenko · 2022-03-24T10:20:29Z

@lguohan , @sujinmkang , @prgeor and @vdahiya12 could you make review of this merge request?

akokhan · 2022-03-25T09:33:53Z

@prgeor , could you please take a look? Thanks

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

VadymYashchenko · 2022-03-28T09:06:12Z

@lguohan , @sujinmkang , @prgeor and @vdahiya12 could you make review of this merge request?

x86_64-acton_as9516_32d-r0 Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

Master merge

VadymYashchenko · 2022-03-29T09:05:53Z

@lguohan , @sujinmkang , @prgeor and @vdahiya12 could you make review of this merge request?

akokhan · 2022-03-30T07:55:22Z

device/barefoot/x86_64-accton_as9516_32d-r0/thermal_thresholds.json

+        {
+            "psu_driver-i2c-7-59:psu2-temp3" : [60.0, 50.0, 11.0, 1.0]
+        },
+		{


Please fix indentation.

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

Master to Vadym master

VadymYashchenko · 2022-04-01T09:07:49Z

@lguohan , @sujinmkang , @prgeor and @vdahiya12 could you make review of this merge request?

akokhan · 2022-04-05T15:50:08Z

@prgeor , please approve and merge

VadymYashchenko added 3 commits January 12, 2022 16:48

Merge pull request #1 from Azure/master

5d62494

12 Jan update

Merge pull request #3 from Azure/master

99acd67

Merge from Azure to VY

Merge pull request #9 from Azure/master

1099b7c

Update 2_2_2022

VadymYashchenko requested review from sujinmkang, prgeor, vdahiya12 and lguohan as code owners March 10, 2022 11:56

VadymYashchenko changed the title ~~Fix thermals test~~ [BFN] Mar 10, 2022

VadymYashchenko changed the title ~~[BFN]~~ [BFN] Refactoring and adding some functions of Thermal class (set and get thresholds and etc.) Mar 10, 2022

VadymYashchenko force-pushed the fix_thermals_test branch from a55320c to 5253e46 Compare March 14, 2022 14:40

VadymYashchenko force-pushed the fix_thermals_test branch from 5253e46 to 5f8bdc5 Compare March 15, 2022 15:16

VadymYashchenko force-pushed the fix_thermals_test branch from 5f8bdc5 to f3f1b50 Compare March 16, 2022 10:07

Merge pull request #13 from Azure/master

090d2c0

Rebase master

VadymYashchenko force-pushed the fix_thermals_test branch from 8e024fe to c733449 Compare March 17, 2022 12:00

VadymYashchenko added 11 commits March 17, 2022 05:18

Revised set_high_thershold and set_low_thershold methobs in the therm…

c5112bf

…al.py Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

Revised set_low_thershold and set_high_thershold

524615e

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

Added separated files with thermal thresholds, changed platform.json and

bd7be5e

thermal.py Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

Revised on code revieww

09de264

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

Reverted thermal.py

119d798

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

Revised ther python.py

edeb1aa

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

Revised due to code review

6d566aa

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

Added fucntion for fix the problem of tofino sensor high critical thr…

337dfe3

…eshold Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

Revised due to code review

d461093

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

Revised due to code review

343f02b

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

Revised due to code review

0e0d0d2

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

VadymYashchenko added 7 commits March 17, 2022 05:18

Revised only for cab18-4

7ce16ea

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

Revised default thresholds

7697573

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

Revised ther def thresholds

d2cee5d

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

Revised on code review

a334ca6

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

Revised platform.json and thermal_thresholds.json

93ebf5e

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

Code review in PR to azure (trigger CI)

5f6b31e

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

Added handle of exception

d76dc14

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

VadymYashchenko force-pushed the fix_thermals_test branch from c733449 to 21c950a Compare March 21, 2022 10:17

Revised exception handler

21c950a

akokhan previously approved these changes Mar 24, 2022

View reviewed changes

VadymYashchenko dismissed akokhan’s stale review via 325e724 March 25, 2022 21:39

Added psu-1 thermal names to platfrom.json

325e724

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

VadymYashchenko added 2 commits March 28, 2022 02:12

Changed platform.json and thermal_thresholds.json in

e53a90f

x86_64-acton_as9516_32d-r0 Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

Merge pull request #15 from Azure/master

14d301c

Master merge

akokhan reviewed Mar 30, 2022

View reviewed changes

VadymYashchenko added 3 commits March 30, 2022 01:38

Removed indentation from json file

3c4d60e

Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com>

Merge pull request #16 from Azure/master

9eede4c

Master to Vadym master

Merge branch 'master' into fix_thermals_test

0bcd159

akokhan approved these changes Mar 31, 2022

View reviewed changes

prgeor approved these changes Apr 5, 2022

View reviewed changes

prgeor merged commit 8e616c1 into sonic-net:master Apr 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BFN] Refactoring and adding some functions of Thermal class (set and get thresholds and etc.) #10205

[BFN] Refactoring and adding some functions of Thermal class (set and get thresholds and etc.) #10205

VadymYashchenko commented Mar 10, 2022 •

edited

Loading

lgtm-com bot commented Mar 14, 2022

lgtm-com bot commented Mar 14, 2022

lgtm-com bot commented Mar 15, 2022

lgtm-com bot commented Mar 16, 2022

lgtm-com bot commented Mar 16, 2022

VadymYashchenko commented Mar 22, 2022

VadymYashchenko commented Mar 24, 2022

akokhan commented Mar 25, 2022

VadymYashchenko commented Mar 28, 2022

VadymYashchenko commented Mar 29, 2022

akokhan Mar 30, 2022

VadymYashchenko Mar 31, 2022

VadymYashchenko commented Apr 1, 2022

akokhan commented Apr 5, 2022

[BFN] Refactoring and adding some functions of Thermal class (set and get thresholds and etc.) #10205

[BFN] Refactoring and adding some functions of Thermal class (set and get thresholds and etc.) #10205

Conversation

VadymYashchenko commented Mar 10, 2022 • edited Loading

Why I did it

How I did it

How to verify it

Description for the changelog

lgtm-com bot commented Mar 14, 2022

lgtm-com bot commented Mar 14, 2022

lgtm-com bot commented Mar 15, 2022

lgtm-com bot commented Mar 16, 2022

lgtm-com bot commented Mar 16, 2022

VadymYashchenko commented Mar 22, 2022

VadymYashchenko commented Mar 24, 2022

akokhan commented Mar 25, 2022

VadymYashchenko commented Mar 28, 2022

VadymYashchenko commented Mar 29, 2022

akokhan Mar 30, 2022

Choose a reason for hiding this comment

VadymYashchenko Mar 31, 2022

Choose a reason for hiding this comment

VadymYashchenko commented Apr 1, 2022

akokhan commented Apr 5, 2022

VadymYashchenko commented Mar 10, 2022 •

edited

Loading