Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact(TVOS): using common example src #2173

Merged
merged 25 commits into from
Jun 11, 2024
Merged

refact(TVOS): using common example src #2173

merged 25 commits into from
Jun 11, 2024

Conversation

alduzy
Copy link
Member

@alduzy alduzy commented Jun 6, 2024

Description

This PR intents to use common examples src directory in TVOS Example app.

The example screens that were removed with tvos specific src folder are all present in the common directory in similar or slightly more complex shape ready to be tested.

Some of the common examples that are being exposed to TVOS by this PR are not working properly as they were not intended to work on TV platform, those are:

  • swipe back animation screen (working well, but without the gesture)
  • animations playground
  • status bar playground
  • orientation playground
  • search bar playground
  • gestures playground
    I decided to filter them out for TV devices.

There are also some issues worth pointing out I found while playing around with the TVOS example:

  • header text and background colors are unchangeable (white on light grey in regular screens and gray on dark gray in modals)
  • the value in the input is not visible until the input is hovered or focused (try it in Stack Presentation -> formSheet)
  • select inputs are not selectable - just expandable, thus not accessible (try it in header options playground)

Changes

  • removed TVOS src directory
  • linked apps/examples/App in TVOS App.tsx
  • added TVOS Platform ternary in common App.tsx file

Test code and steps to reproduce

Checklist

Base automatically changed from @alduzy/rebuild-tvosexample to main June 10, 2024 11:40
apps/examples/App.tsx Outdated Show resolved Hide resolved
apps/examples/App.tsx Outdated Show resolved Hide resolved
@alduzy alduzy requested a review from maciekstosio June 11, 2024 08:22
Copy link
Contributor

@maciekstosio maciekstosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to consider rest looks ok 🚀

apps/examples/App.tsx Show resolved Hide resolved
apps/examples/App.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants