Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(TVOS): rebuild TVOSExample app with RN 0.74.1 #2155

Merged
merged 18 commits into from
Jun 10, 2024
Merged

chore(TVOS): rebuild TVOSExample app with RN 0.74.1 #2155

merged 18 commits into from
Jun 10, 2024

Conversation

alduzy
Copy link
Member

@alduzy alduzy commented May 22, 2024 •
edited
Loading

Description

PR rebuilding TVOSExample from scratch with RN 0.74.1.

Changes

  • rebuild TVOSExample app with latest RN version

Test code and steps to reproduce

Checklist

@alduzy alduzy requested review from tboba and WoLewicki May 22, 2024 12:55
@alduzy alduzy requested a review from kkafar May 22, 2024 14:34
kkafar
kkafar reviewed May 27, 2024
View reviewed changes
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to make CI work before we proceed here. It does somehow build on main, wo we should be able to make it work here too (as well as running it locally).

@alduzy alduzy requested a review from kkafar May 28, 2024 13:52
tboba
tboba requested changes Jun 7, 2024
View reviewed changes
Copy link
Member

@tboba tboba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🥳

.github/workflows/tv-os-build-test.yml Outdated Show resolved Hide resolved
.github/workflows/tv-os-build-test.yml Show resolved Hide resolved
TVOSExample/.watchmanconfig Show resolved Hide resolved
TVOSExample/android/app/build.gradle Show resolved Hide resolved
TVOSExample/android/app/src/main/res/drawable/tv_banner.png Outdated Show resolved Hide resolved
TVOSExample/ios/Podfile Show resolved Hide resolved
TVOSExample/src/BottomTabsExample.tsx Outdated Show resolved Hide resolved
@alduzy alduzy requested a review from tboba June 10, 2024 09:18
tboba
tboba approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@tboba tboba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay then 👍

@alduzy alduzy merged commit e35da5a into main Jun 10, 2024
2 checks passed
@alduzy alduzy deleted the @alduzy/rebuild-tvosexample branch June 10, 2024 11:40
@toomeem toomeem mentioned this pull request Jul 10, 2024
Merged
@2lambda123 2lambda123 mentioned this pull request Jul 11, 2024
Merged
@shonore shonore mentioned this pull request Jul 17, 2024
Open
@ismaelgansonre ismaelgansonre mentioned this pull request Jul 17, 2024
Open
@DAVAS110 DAVAS110 mentioned this pull request Jul 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tboba tboba tboba approved these changes

@WoLewicki WoLewicki Awaiting requested review from WoLewicki

@kkafar kkafar Awaiting requested review from kkafar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alduzy @tboba @kkafar