Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaExplicitOdeSolver] Introduce visitor to know the number of non-diagonal mass matrices #2165

Merged
merged 9 commits into from
Jun 28, 2021
Merged

[SofaExplicitOdeSolver] Introduce visitor to know the number of non-diagonal mass matrices #2165

merged 9 commits into from
Jun 28, 2021

Conversation

alxbilger
Copy link
Contributor

@alxbilger alxbilger commented Jun 7, 2021 •
edited
Loading

  • Introduce visitor to know the number of non-diagonal mass matrices
  • Use this new visitor in EulerExplicitSolver to apply the optimization based on diagonal matrices, or not.

This PR is based on #2163

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added enhancement About a possible enhancement pr: breaking Change possibly inducing a compilation error pr: status to review To notify reviewers to review this pull-request labels Jun 7, 2021
@alxbilger
Copy link
Contributor Author

[ci-build][with-all-tests]

@fredroy
Copy link
Contributor

fredroy commented Jun 23, 2021

Ready when #2163 is ready

@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Jun 23, 2021
@alxbilger alxbilger requested a review from hugtalbot June 24, 2021 08:17
@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Jun 24, 2021
@alxbilger
Copy link
Contributor Author

[ci-build][with-all-tests]

@alxbilger alxbilger mentioned this pull request Jun 24, 2021
Merged
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jun 28, 2021
@alxbilger
Merge remote-tracking branch 'upstream/master' into diag_visitor
e41883a 
# Conflicts:
#	SofaKernel/modules/SofaExplicitOdeSolver/src/SofaExplicitOdeSolver/EulerSolver.cpp
#	SofaKernel/modules/SofaExplicitOdeSolver/src/SofaExplicitOdeSolver/EulerSolver.h
@epernod epernod merged commit 2367858 into sofa-framework:master Jun 28, 2021
@guparan guparan changed the title [SofaExplicitOdelSolver] Introduce visitor to know the number of non-diagonal mass matrices [SofaExplicitOdeSolver] Introduce visitor to know the number of non-diagonal mass matrices Jun 29, 2021
@guparan guparan added this to the v21.06 milestone Jun 30, 2021
@alxbilger alxbilger mentioned this pull request Oct 12, 2021
Closed
@alxbilger alxbilger deleted the diag_visitor branch June 28, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot Awaiting requested review from hugtalbot

Assignees
No one assigned
Labels
enhancement About a possible enhancement pr: breaking Change possibly inducing a compilation error pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.06
Development

Successfully merging this pull request may close these issues.
5 participants
@alxbilger @fredroy @hugtalbot @guparan @epernod